Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CS2113-T13-1] MoneyMoover #26

Open
wants to merge 789 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
789 commits
Select commit Hold shift + click to select a range
d10b077
Update UG
Gan868611 Mar 29, 2023
27ab178
Fix bug
Gan868611 Mar 29, 2023
cfa8eba
Merge branch 'master' of https://github.com/AY2223S2-CS2113-T13-1/tp
Gan868611 Mar 29, 2023
8839bb5
Merge branch 'master' into Update-UG
Gan868611 Mar 29, 2023
ac2881d
Fix typo
jacob-stein1 Mar 29, 2023
c8c5341
Merge pull request #111 from jacob-stein1/default-rates
jacob-stein1 Mar 29, 2023
1e92a0c
Remove duplicated code
Gan868611 Mar 29, 2023
fc26ed9
Fix bugs
Gan868611 Mar 29, 2023
d2c68f5
Merge pull request #112 from Gan868611/Update-UG
woowenjun99 Mar 29, 2023
79c0d77
test
Gan868611 Mar 29, 2023
d0f6381
Merge pull request #113 from Gan868611/Bug-fix-decimalRounding
woowenjun99 Mar 29, 2023
58ab9a6
Merge branch 'master' of https://github.com/AY2223S2-CS2113-T13-1/tp
Gan868611 Mar 29, 2023
6570835
Merge branch 'master' of https://github.com/AY2223S2-CS2113-T13-1/tp
jacob-stein1 Mar 29, 2023
190686f
Add the ability to write to file.
Bawfen Mar 29, 2023
4f80485
Update the error message
woowenjun99 Mar 29, 2023
cac308c
Merge from master
Bawfen Mar 29, 2023
a7b844a
Complete the edit
woowenjun99 Mar 29, 2023
8b7308d
Return early from save if there is an exception
Bawfen Mar 29, 2023
288899c
Fix logging message in TransactionManager
Bawfen Mar 29, 2023
85f9278
Update API Key
Bawfen Mar 29, 2023
5ed9b29
Fix bug with LocalDateTimeAdapter
Bawfen Mar 29, 2023
cb1e711
Merge pull request #115 from Bawfen/Add-Persistence
woowenjun99 Mar 29, 2023
1df4f20
Merge branch 'master' of https://github.com/AY2223S2-CS2113-T13-1/tp
Gan868611 Mar 29, 2023
5a572ee
Fix issue with balances being saved and loaded wrongly
Bawfen Mar 29, 2023
162429c
Merge pull request #117 from Bawfen/Add-Persistence
Bawfen Mar 29, 2023
0c6a79f
Merge branch 'master' of https://github.com/AY2223S2-CS2113-T13-1/tp
Gan868611 Mar 29, 2023
02a9c1a
Merge pull request #116 from woowenjun99/fix-up-the-dg
Bawfen Mar 29, 2023
3b57a0e
Fix typo in DeveloperGuide
Bawfen Mar 30, 2023
1ef4a2e
Merge pull request #118 from Bawfen/Fix-DG
Bawfen Mar 30, 2023
de5f336
Merge branch 'master' of https://github.com/AY2223S2-CS2113-T13-1/tp
Gan868611 Apr 1, 2023
03f3555
Update UG
Gan868611 Apr 1, 2023
1ac6ded
Update UG
Gan868611 Apr 1, 2023
eea36f0
Edit format of indentation
Gan868611 Apr 1, 2023
55b8a5d
Modify command summary table
Gan868611 Apr 1, 2023
5c306e0
Fix the exit command not immediately terminating the program
Arif-Khalid Apr 1, 2023
cb1ae6d
Merge pull request #178 from Arif-Khalid/arifKhalid-FixExitCommand
Bawfen Apr 1, 2023
18a71f4
Merge branch 'master' of https://github.com/AY2223S2-CS2113-T13-1/tp
jacob-stein1 Apr 3, 2023
ff48f1c
Reformat command summary
Gan868611 Apr 3, 2023
d3c02bc
Modify exception message
Gan868611 Apr 3, 2023
406b2f9
Fix coding style
Gan868611 Apr 3, 2023
907ec85
Add notes
Gan868611 Apr 3, 2023
a1424b5
Fix bugs
Gan868611 Apr 3, 2023
2c054e8
Fix bugs
Gan868611 Apr 3, 2023
785ede5
Fix bugs
Gan868611 Apr 3, 2023
37845a6
Add new limitations on show-rate to UG
jacob-stein1 Apr 3, 2023
d98a745
Add min and max value to show-rate
jacob-stein1 Apr 3, 2023
a7565c7
Add confirmation message for API initialization
jacob-stein1 Apr 3, 2023
3af4111
Change API key
jacob-stein1 Apr 3, 2023
060fb8c
Revert pause to 5 seconds for API call
jacob-stein1 Apr 3, 2023
d51fd90
Expand show-rate testing for new boundary checks
jacob-stein1 Apr 3, 2023
d954610
Remove float as intermediary in show-rate parsing
jacob-stein1 Apr 4, 2023
9fc8679
Specify missing accounts with exchange command
jacob-stein1 Apr 4, 2023
aa98d08
Fix bug
woowenjun99 Apr 4, 2023
0d04e67
Outline for jacob-stein1 PPP
jacob-stein1 Apr 4, 2023
d96d334
Add API contribution
jacob-stein1 Apr 4, 2023
7f71672
Merge remote-tracking branch 'AY2223S2-CS2113-T13-1/master'
Arif-Khalid Apr 4, 2023
e2a1b1d
Fixed too precise amount issues and error in detecting wrong dates
Arif-Khalid Apr 4, 2023
da4d7a9
Fix checkstyle issues in commands
Arif-Khalid Apr 4, 2023
50586a2
Finish JS PPP
jacob-stein1 Apr 5, 2023
5df4673
Update JS PPP
jacob-stein1 Apr 5, 2023
89c3c9f
Cut PPP text
jacob-stein1 Apr 5, 2023
f2a2723
Add DAYS_IN_MONTH constant hashmap for clarity
Arif-Khalid Apr 6, 2023
76f81a5
Fix checkstyle errors in DateConstants
Arif-Khalid Apr 6, 2023
4f65164
WIP on PPP
Arif-Khalid Apr 6, 2023
fd89589
Add Draft for PPP
Arif-Khalid Apr 6, 2023
7c28060
Update AboutUs
Arif-Khalid Apr 6, 2023
d7f411c
Reduce length of PPP
Arif-Khalid Apr 6, 2023
c5ad468
Remove redundant log file
Arif-Khalid Apr 6, 2023
0de1bea
Merge pull request #182 from Gan868611/Wrong-WithdrawComannd-Exceptio…
Bawfen Apr 6, 2023
b5dd3d2
Merge pull request #186 from woowenjun99/170-pe-dtester-a-cannot-tack…
Bawfen Apr 6, 2023
6c35405
Merge branch 'master' of https://github.com/AY2223S2-CS2113-T13-1/tp
Gan868611 Apr 7, 2023
4530c53
Merge branch 'master' into Limit-description-100char
Gan868611 Apr 7, 2023
85df2b9
Update JS PPP
jacob-stein1 Apr 7, 2023
ac676fe
Edit description message
Gan868611 Apr 7, 2023
6cffb74
Merge remote-tracking branch 'AY2223S2-CS2113-T13-1/master'
Arif-Khalid Apr 7, 2023
1cfdec5
Merge branch 'master' into Update-UG-PED
Gan868611 Apr 7, 2023
64514ef
Add comments clarifying exceptions
jacob-stein1 Apr 7, 2023
488186c
Merge branch 'master' into show-rate-ped
jacob-stein1 Apr 7, 2023
5758158
Limit desc to 100 char
Gan868611 Apr 7, 2023
228dc9a
Merge pull request #184 from jacob-stein1/show-rate-ped
Bawfen Apr 7, 2023
8948e49
Merge branch 'master' into arifKhalid-FixPEDryRunIssues
Arif-Khalid Apr 7, 2023
bc97d88
Merge branch 'master' of https://github.com/AY2223S2-CS2113-T13-1/tp
Gan868611 Apr 7, 2023
6e190ae
Merge branch 'master' into Limit-description-100char
Gan868611 Apr 7, 2023
4afafa3
Merge pull request #188 from Arif-Khalid/arifKhalid-FixPEDryRunIssues
Bawfen Apr 7, 2023
b2da898
Fix exception naming convention
jacob-stein1 Apr 7, 2023
650172e
Merge branch 'master' into exchange-cmd-ped
jacob-stein1 Apr 7, 2023
a0b18d7
Merge branch 'master' of https://github.com/AY2223S2-CS2113-T13-1/tp
Gan868611 Apr 7, 2023
f1012e8
Merge pull request #185 from jacob-stein1/exchange-cmd-ped
Bawfen Apr 7, 2023
9e8a1c6
Merge branch 'master' into Limit-description-100char
Gan868611 Apr 7, 2023
5a8bdb7
Merge branch 'master' of https://github.com/AY2223S2-CS2113-T13-1/tp
Gan868611 Apr 7, 2023
801f353
Merge branch 'master' into Limit-description-100char
Gan868611 Apr 7, 2023
095ee33
Merge pull request #190 from Arif-Khalid/arifKhalid-PPP
jacob-stein1 Apr 7, 2023
0db5595
Merge pull request #183 from Gan868611/Limit-description-100char
jacob-stein1 Apr 7, 2023
1b51fe6
Merge branch 'master' into Update-UG-PED
Gan868611 Apr 7, 2023
9472bc3
Merge branch 'master' of https://github.com/AY2223S2-CS2113-T13-1/tp
Gan868611 Apr 7, 2023
3111f7f
Merge branch 'master' into Update-UG-PED
Gan868611 Apr 7, 2023
1915cc4
Fix bugs
Gan868611 Apr 7, 2023
72886cb
Merge pull request #177 from Gan868611/Update-UG-PED
jacob-stein1 Apr 7, 2023
d61186f
Merge branch 'master' of https://github.com/AY2223S2-CS2113-T13-1/tp
Gan868611 Apr 7, 2023
5427632
Merge branch 'master' of https://github.com/AY2223S2-CS2113-T13-1/tp …
jacob-stein1 Apr 7, 2023
a0ed67e
Add photo to AboutUs
jacob-stein1 Apr 7, 2023
6ee2dee
Correct path for portfolio link
jacob-stein1 Apr 7, 2023
a46a3cd
Add in a trim to ensure consistency in the input
woowenjun99 Apr 7, 2023
5d33df6
Fix issue with rendering extracts
jacob-stein1 Apr 7, 2023
a4112dc
Adjusted the error message
woowenjun99 Apr 7, 2023
ddcbf0a
Merge remote-tracking branch 'AY2223S2-CS2113-T13-1/master'
Arif-Khalid Apr 7, 2023
d7496b1
Fix error in Transaction Command UG documentation
Arif-Khalid Apr 7, 2023
832ad74
Merge pull request #194 from Arif-Khalid/arifKhalid-FixErrorInUG
jacob-stein1 Apr 7, 2023
69a3913
Merge pull request #192 from jacob-stein1/jacob-stein-ppp
jacob-stein1 Apr 7, 2023
39827a2
Merge pull request #193 from woowenjun99/187-bug-withdraw-and-add-com…
jacob-stein1 Apr 7, 2023
424b906
Add check for gson parse errors and creates a new file if any are enc…
Bawfen Apr 7, 2023
187e26a
Move unknown command error message to ErrorMessage for consistency
Bawfen Apr 7, 2023
2aa284a
Update UserGuide Notes section with storage related information
Bawfen Apr 7, 2023
ef81ea9
Adds default values if the balances in the locally saved files are in…
Bawfen Apr 7, 2023
39f5106
Add PPP and image
Bawfen Apr 7, 2023
535309d
Merge pull request #197 from Bawfen/PPP-Ben
Bawfen Apr 7, 2023
49026b0
Remove unused variables
woowenjun99 Apr 7, 2023
ebcf2c3
Create an InvalidBigDecimalException
woowenjun99 Apr 7, 2023
2abbc55
Create a validator class
woowenjun99 Apr 7, 2023
ce7aafc
Integrate the validator class into the 2 commands
woowenjun99 Apr 7, 2023
23dd9c1
Update the AddCommand and WithdrawCommand
woowenjun99 Apr 7, 2023
8f528fb
Update the value of the validator class
woowenjun99 Apr 7, 2023
8c9d7e3
Integrate in the error message into the validator class
woowenjun99 Apr 7, 2023
208ef76
Make transactions final
woowenjun99 Apr 7, 2023
45a103f
Drafting the PPP
woowenjun99 Apr 7, 2023
76cc979
Update docs
woowenjun99 Apr 7, 2023
6787447
Update PPP with the sequence diagram
woowenjun99 Apr 7, 2023
31ba245
Add final touches to the PPP
woowenjun99 Apr 7, 2023
c7f0e79
Merge pull request #198 from woowenjun99/153-ped
jacob-stein1 Apr 8, 2023
47458aa
Merge pull request #199 from woowenjun99/wen-jun-ppp
jacob-stein1 Apr 8, 2023
54f5759
Merge branch 'master' of https://github.com/AY2223S2-CS2113-T13-1/tp
jacob-stein1 Apr 8, 2023
91a29f4
Implement validator in exchange
jacob-stein1 Apr 8, 2023
b60e00f
Implement validator in show-rate
jacob-stein1 Apr 8, 2023
4abaa53
Merge pull request #200 from jacob-stein1/implement-validator
Bawfen Apr 8, 2023
5cb6342
Merge from master
Bawfen Apr 8, 2023
15e2219
Made UPPER_BOUND and LOWER_BOUND in Validator final to pass code styl…
Bawfen Apr 8, 2023
7ef4b3b
Merge branch 'master' of https://github.com/AY2223S2-CS2113-T13-1/tp
Gan868611 Apr 8, 2023
30462e9
Merge branch 'master' into Update-UG-PED
Gan868611 Apr 8, 2023
47cc55b
Modify all Currency enum checks to uppercase by default, allowing use…
Bawfen Apr 8, 2023
d4dae56
Update help message
Gan868611 Apr 8, 2023
64e1623
Rename all packages to com.moneymoover and replaces all mentions of D…
Bawfen Apr 8, 2023
4e1e13f
create PPP
Gan868611 Apr 8, 2023
301f9c0
rebuild pages
Gan868611 Apr 8, 2023
c68e4dd
fix bug
Gan868611 Apr 8, 2023
fb795a3
fix bugs
Gan868611 Apr 8, 2023
f145c77
Merge pull request #202 from Bawfen/147-currency-uppercase
Bawfen Apr 8, 2023
bcbf81a
Merge branch 'master' into Update_developer_guide
Gan868611 Apr 8, 2023
be6c217
Merge branch 'master' of https://github.com/AY2223S2-CS2113-T13-1/tp
Gan868611 Apr 8, 2023
e1df33d
Merge branch 'master' into Update-UG-PED
Gan868611 Apr 8, 2023
02ff340
Merge branch 'master' into Update-DG
Gan868611 Apr 8, 2023
6ff4fbd
Merge pull request #201 from Gan868611/Update-UG-PED
woowenjun99 Apr 8, 2023
9f2c39e
Merge pull request #203 from Gan868611/Gan-Zhen-Yang-PPP
jacob-stein1 Apr 8, 2023
05e60e2
Merge from master
Bawfen Apr 8, 2023
9d70487
Modify UG help to be the same as the output of the help command
Bawfen Apr 8, 2023
d86556f
Merge pull request #195 from Bawfen/119-program-crashes-if-the-json-f…
Bawfen Apr 8, 2023
485c6cd
Add section on currency and date related inputs to the UG
Bawfen Apr 8, 2023
f7deacd
Fix sequence diagram
Gan868611 Apr 9, 2023
8dec943
Merge branch 'master' of https://github.com/AY2223S2-CS2113-T13-1/tp
Gan868611 Apr 9, 2023
56d5fd1
Merge pull request #205 from Bawfen/AddDateInputToUG
woowenjun99 Apr 9, 2023
8f7de3a
Merge pull request #204 from Gan868611/Update-DG
Bawfen Apr 9, 2023
cecebd2
Remove files in wrong directory
Bawfen Apr 9, 2023
c333260
Merge pull request #210 from Bawfen/RemoveRedundantFiles
woowenjun99 Apr 9, 2023
733a837
Add in the message for balances
woowenjun99 Apr 9, 2023
6d0439a
Refactor getAccounts
woowenjun99 Apr 9, 2023
1e2431a
Merge branch 'master' of https://github.com/AY2223S2-CS2113-T13-1/tp
jacob-stein1 Apr 9, 2023
aa4de40
Remove ability to exchange between same currency
jacob-stein1 Apr 9, 2023
f37505b
Add descriptions for exceptions that do not have one
jacob-stein1 Apr 9, 2023
55bacea
Add JUnit test for same currency exception
jacob-stein1 Apr 9, 2023
f367b91
Add assertion checks to API and commands using validator
jacob-stein1 Apr 9, 2023
b29bc77
Merge pull request #214 from jacob-stein1/remove-exchange-between-sam…
woowenjun99 Apr 9, 2023
adfa4d9
Merge pull request #213 from woowenjun99/issue-206-better-description…
Bawfen Apr 9, 2023
89f6f42
Add spacing to Message enum
Bawfen Apr 9, 2023
549504c
Add NFR, User Stories, Acknowledgements and Instructions for updating…
Bawfen Apr 9, 2023
b3f67eb
Fix typo
Bawfen Apr 9, 2023
076bfc2
Merge pull request #215 from Bawfen/FixDG
jacob-stein1 Apr 9, 2023
22bb123
Fix typo in Setting Up and hyperlink in Appendix
Bawfen Apr 10, 2023
683d2b5
Add the Instructions for Manual Testing section
Bawfen Apr 10, 2023
d03d3c6
Merge branch 'master' of https://github.com/AY2223S2-CS2113-T13-1/tp
jacob-stein1 Apr 10, 2023
892a35c
Implement target exchange minimum
jacob-stein1 Apr 10, 2023
eb95a52
Add logging to API
jacob-stein1 Apr 10, 2023
cc9d98a
Fix rounding error
jacob-stein1 Apr 10, 2023
58abe23
Merge pull request #217 from jacob-stein1/minimum-exchange-target
Bawfen Apr 10, 2023
63b86f2
Merge from master
Bawfen Apr 10, 2023
fadd4ed
Update API Key and PPP
Bawfen Apr 10, 2023
005ba0a
Add line about internet connection
Bawfen Apr 10, 2023
206a903
Fix bug where the amount loaded from file was wrong due to floating p…
Bawfen Apr 10, 2023
239bbed
Uncommenting API key
Bawfen Apr 10, 2023
c56c6e8
Merge pull request #216 from Bawfen/ManualTestingInstructions
Arif-Khalid Apr 10, 2023
93c7686
Merge remote-tracking branch 'AY2223S2-CS2113-T13-1/master'
Arif-Khalid Apr 10, 2023
63b94b0
Fix standardisation of UG
Arif-Khalid Apr 10, 2023
179054c
Fix more standardisation errors in UG
Arif-Khalid Apr 10, 2023
2b379ca
Merge branch 'master' of https://github.com/AY2223S2-CS2113-T13-1/tp
Gan868611 Apr 10, 2023
0487ab3
Merge branch 'master' into Update-DG
Gan868611 Apr 10, 2023
cc07c50
Add further conditions for description in add and withdraw command
Arif-Khalid Apr 10, 2023
6cf017a
Modify seq diagram
Gan868611 Apr 10, 2023
668bc0a
Remove unnecessary spaces in UG
Arif-Khalid Apr 10, 2023
6811da8
Fix formatting in example help command
Arif-Khalid Apr 10, 2023
df108f0
Fix formatting in help command again
Arif-Khalid Apr 10, 2023
637a62d
Fix to help command formatting missing spaces
Arif-Khalid Apr 10, 2023
4693307
Fix hyperlink
Gan868611 Apr 10, 2023
5c5b521
Fix spacing error in withdraw example command
Arif-Khalid Apr 10, 2023
a4eb741
Merge pull request #226 from Arif-Khalid/arifKhalid-StandardiseDocume…
Bawfen Apr 10, 2023
28edf8b
Change Appendix header to use hyphen instead of colon
Bawfen Apr 10, 2023
eaa0624
Edit delete-account and create-account seq diagram
Gan868611 Apr 10, 2023
ae8b4fc
Fix Balance Sequence Diagram
Arif-Khalid Apr 10, 2023
fb489a8
Edit exchange seq diagram
Gan868611 Apr 10, 2023
dd63f6b
Update the Balance UG
woowenjun99 Apr 10, 2023
f2fbf28
Update the PPP
woowenjun99 Apr 10, 2023
6b4ad91
Add Storage Component to DG
Bawfen Apr 10, 2023
1738fb4
Merge branch 'master' into update-wen-ppp
woowenjun99 Apr 10, 2023
4d21813
Fix to PPP
Bawfen Apr 10, 2023
0cd1cce
Add Storage to TOC
Bawfen Apr 10, 2023
210f63d
Fix links in DG
Bawfen Apr 10, 2023
f36f704
Update the UI aspect of the class diagram
woowenjun99 Apr 10, 2023
1ab2830
Merge pull request #228 from woowenjun99/update-wen-ppp
Bawfen Apr 10, 2023
ca937db
Merge pull request #229 from woowenjun99/update-ui-dg
Bawfen Apr 10, 2023
47cd2ed
Update the parser for the dg
woowenjun99 Apr 10, 2023
f838b34
Merge pull request #230 from woowenjun99/update-parser-dg
Bawfen Apr 10, 2023
a95dc11
Fix BasicSequence
Bawfen Apr 10, 2023
e9175ce
Add return arrow to ShowTransactionsSeq
Bawfen Apr 10, 2023
5100cbf
Add colon for TransactionCommand instance
Bawfen Apr 10, 2023
b246807
Fix errors in show rate sequence diagram
Arif-Khalid Apr 10, 2023
9607e52
Modify add, withdraw seq diagram
Gan868611 Apr 10, 2023
d74906a
Update the account list dg
woowenjun99 Apr 10, 2023
a7303b2
Merge pull request #231 from woowenjun99/update-accounts-dg
Bawfen Apr 10, 2023
a12671c
Merge branch 'master' of https://github.com/AY2223S2-CS2113-T13-1/tp
Gan868611 Apr 10, 2023
3892da8
Add name to entity in show rate sequence diagram
Arif-Khalid Apr 10, 2023
7cbe8e3
Merge branch 'master' of https://github.com/AY2223S2-CS2113-T13-1/tp
Bawfen Apr 10, 2023
473d3d0
Merge branch 'master' into Update-DG
Gan868611 Apr 10, 2023
f6c53ec
Merge from master
Bawfen Apr 10, 2023
d721379
Update the Forex component
woowenjun99 Apr 10, 2023
ac8e9cb
Fix frames of balance diagram in front of activation boxes
Arif-Khalid Apr 10, 2023
36cce8e
Update ShowTransactionsSeqDiagram
Bawfen Apr 10, 2023
a1f59ea
Revert "Fix frames of balance diagram in front of activation boxes"
Arif-Khalid Apr 10, 2023
8f3bcd9
Move alt frame to the back (all seq diagram)
Gan868611 Apr 10, 2023
9063f46
Update the ForexComponent
woowenjun99 Apr 10, 2023
1b18837
Fix frames of balance diagram in front of activation box
Arif-Khalid Apr 10, 2023
ca64950
Merge pull request #233 from woowenjun99/update-forex-dg
Bawfen Apr 10, 2023
9783a11
Fix frames of show rate sequence diagrams in front of activation box
Arif-Khalid Apr 10, 2023
8fb55c2
Fix alt frame
Gan868611 Apr 10, 2023
cd5d169
delete extra files
Gan868611 Apr 10, 2023
1666634
Merge pull request #227 from Gan868611/Update-DG
Bawfen Apr 10, 2023
8613e45
Update BasicSequence diagram
Bawfen Apr 10, 2023
6ee801a
Merge from master
Bawfen Apr 10, 2023
c4c8e12
Merge remote-tracking branch 'AY2223S2-CS2113-T13-1/master'
Arif-Khalid Apr 10, 2023
67f4a99
Merge branch 'master' into arifKhalid-DGShowRateAndBalanceCommand
Arif-Khalid Apr 10, 2023
a68d088
Merge pull request #236 from Arif-Khalid/arifKhalid-DGShowRateAndBala…
jacob-stein1 Apr 10, 2023
0451d9d
Merge pull request #234 from Bawfen/AddStorageToDG
Arif-Khalid Apr 10, 2023
0ae8d42
Update the ppp
woowenjun99 Apr 10, 2023
521a649
Merge pull request #237 from woowenjun99/update-ppp
Bawfen Apr 10, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
78 changes: 78 additions & 0 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,78 @@
<!-- This PR Template is taken with inspiration from kubernetes's open source repo: https://github.com/kubernetes/kubernetes/blob/master/.github/PULL_REQUEST_TEMPLATE.md
-->

# Description

<!--- Please include a short summary of the change -->

## Type of Change

- [ ] Possible breaking change (Change in feature that may cause existing features to not work correctly, e.g. change in
schema)
- [ ] Non breaking change (Bug fix, New feature)

## What type of PR is this?

<!--
Add one of the following kinds:
- Bug Fix
- Clean Up
- Documentation
- Feature
-->

- [ ] bug fix
- [ ] cleanup
- [ ] documentation
- [ ] feature

## What this PR does / Why we need it:

```docs

```

## Which issue(s) this PR fixes, if:

<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
keywords:
- `close`
- `closes`
- `closed`
- `fix`
- `fixes`
- `fixed`
- `resolve`
- `resolves`
- `resolved`
-->

Fixes #

## Special notes for your reviewer:

#### Additional documentation e.g., usage docs, testing docs etc.:

<!--
This section can be blank if this pull request does not require a release note.
When adding links which point to resources within git repositories, like the
supporting documentations, please reference a specific commit and avoid
linking directly to the master branch. This ensures that links reference a
specific point in time, rather than a document that may change over time.
See here for guidance on getting permanent links to files: https://help.github.com/en/articles/getting-permanent-links-to-files
Please use the following format for linking documentation:
- [Usage]: <link>
- [Other doc]: <link>
-->

```docs

```

## Checklist

- [ ] Changes have been tested
- [ ] All automated tests pass
- [ ] Relevant Tags and Milestones have been added
30 changes: 15 additions & 15 deletions .github/workflows/gradle.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,18 +33,18 @@ jobs:
- name: Build and check with Gradle
run: ./gradlew check

- name: Perform IO redirection test (*NIX)
if: runner.os == 'Linux'
working-directory: ${{ github.workspace }}/text-ui-test
run: ./runtest.sh

- name: Perform IO redirection test (MacOS)
if: always() && runner.os == 'macOS'
working-directory: ${{ github.workspace }}/text-ui-test
run: ./runtest.sh

- name: Perform IO redirection test (Windows)
if: always() && runner.os == 'Windows'
working-directory: ${{ github.workspace }}/text-ui-test
shell: cmd
run: runtest.bat
# - name: Perform IO redirection test (*NIX)
# if: runner.os == 'Linux'
# working-directory: ${{ github.workspace }}/text-ui-test
# run: ./runtest.sh
#
# - name: Perform IO redirection test (MacOS)
# if: always() && runner.os == 'macOS'
# working-directory: ${{ github.workspace }}/text-ui-test
# run: ./runtest.sh
#
# - name: Perform IO redirection test (Windows)
# if: always() && runner.os == 'Windows'
# working-directory: ${{ github.workspace }}/text-ui-test
# shell: cmd
# run: runtest.bat
4 changes: 4 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,7 @@ bin/

/text-ui-test/ACTUAL.TXT
text-ui-test/EXPECTED-UNIX.TXT

data/
log.txt
log.txt.lck
6 changes: 6 additions & 0 deletions DefaultCodeStyle.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
<code_scheme name="Default" version="173">
<codeStyleSettings language="JAVA">
<option name="INDENT_CASE_FROM_SWITCH" value="false" />
<option name="SPACE_BEFORE_METHOD_PARENTHESES" value="true" />
</codeStyleSettings>
</code_scheme>
71 changes: 11 additions & 60 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,64 +1,15 @@
# Duke project template
# MoneyMoover

This is a project template for a greenfield Java project. It's named after the Java mascot _Duke_. Given below are instructions on how to use it.
MoneyMoover is a **CLI application for managing and transferring international currencies**, optimized for use via a
Command Line Interface (CLI)
while still having the features of other money management applications.

## Setting up in Intellij
Our app will help students to **track their expenses and income** in order to stay within their budgets, so that they
have enough money to travel.
It will also help them convert to foreign currencies so they can see how much they have to spend overseas.

Prerequisites: JDK 11 (use the exact version), update Intellij to the most recent version.
Useful links:

1. **Ensure Intellij JDK 11 is defined as an SDK**, as described [here](https://www.jetbrains.com/help/idea/sdk.html#set-up-jdk) -- this step is not needed if you have used JDK 11 in a previous Intellij project.
1. **Import the project _as a Gradle project_**, as described [here](https://se-education.org/guides/tutorials/intellijImportGradleProject.html).
1. **Verify the set up**: After the importing is complete, locate the `src/main/java/seedu/duke/Duke.java` file, right-click it, and choose `Run Duke.main()`. If the setup is correct, you should see something like the below:
```
> Task :compileJava
> Task :processResources NO-SOURCE
> Task :classes

> Task :Duke.main()
Hello from
____ _
| _ \ _ _| | _____
| | | | | | | |/ / _ \
| |_| | |_| | < __/
|____/ \__,_|_|\_\___|

What is your name?
```
Type some word and press enter to let the execution proceed to the end.

## Build automation using Gradle

* This project uses Gradle for build automation and dependency management. It includes a basic build script as well (i.e. the `build.gradle` file).
* If you are new to Gradle, refer to the [Gradle Tutorial at se-education.org/guides](https://se-education.org/guides/tutorials/gradle.html).

## Testing

### I/O redirection tests

* To run _I/O redirection_ tests (aka _Text UI tests_), navigate to the `text-ui-test` and run the `runtest(.bat/.sh)` script.

### JUnit tests

* A skeleton JUnit test (`src/test/java/seedu/duke/DukeTest.java`) is provided with this project template.
* If you are new to JUnit, refer to the [JUnit Tutorial at se-education.org/guides](https://se-education.org/guides/tutorials/junit.html).

## Checkstyle

* A sample CheckStyle rule configuration is provided in this project.
* If you are new to Checkstyle, refer to the [Checkstyle Tutorial at se-education.org/guides](https://se-education.org/guides/tutorials/checkstyle.html).

## CI using GitHub Actions

The project uses [GitHub actions](https://github.com/features/actions) for CI. When you push a commit to this repo or PR against it, GitHub actions will run automatically to build and verify the code as updated by the commit/PR.

## Documentation

`/docs` folder contains a skeleton version of the project documentation.

Steps for publishing documentation to the public:
1. If you are using this project template for an individual project, go your fork on GitHub.<br>
If you are using this project template for a team project, go to the team fork on GitHub.
1. Click on the `settings` tab.
1. Scroll down to the `GitHub Pages` section.
1. Set the `source` as `master branch /docs folder`.
1. Optionally, use the `choose a theme` button to choose a theme for your documentation.
* [User Guide](docs/UserGuide.md)
* [Developer Guide](docs/DeveloperGuide.md)
* [About Us](docs/AboutUs.md)
9 changes: 6 additions & 3 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ repositories {
dependencies {
testImplementation group: 'org.junit.jupiter', name: 'junit-jupiter-api', version: '5.5.0'
testRuntimeOnly group: 'org.junit.jupiter', name: 'junit-jupiter-engine', version: '5.5.0'
implementation 'com.squareup.retrofit2:retrofit:2.7.0'
implementation 'com.squareup.retrofit2:converter-gson:2.7.0'
implementation 'com.google.code.gson:gson:2.10.1'
}

test {
Expand All @@ -29,18 +32,18 @@ test {
}

application {
mainClass = "seedu.duke.Duke"
mainClass = "com.moneymoover.MoneyMoover"
}

shadowJar {
archiveBaseName = "duke"
archiveBaseName = "moneymoover"
archiveClassifier = null
}

checkstyle {
toolVersion = '10.2'
}

run{
run {
standardInput = System.in
}
14 changes: 7 additions & 7 deletions docs/AboutUs.md
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
# About us

Display | Name | Github Profile | Portfolio
--------|:----:|:--------------:|:---------:
![](https://via.placeholder.com/100.png?text=Photo) | John Doe | [Github](https://github.com/) | [Portfolio](docs/team/johndoe.md)
![](https://via.placeholder.com/100.png?text=Photo) | Don Joe | [Github](https://github.com/) | [Portfolio](docs/team/johndoe.md)
![](https://via.placeholder.com/100.png?text=Photo) | Ron John | [Github](https://github.com/) | [Portfolio](docs/team/johndoe.md)
![](https://via.placeholder.com/100.png?text=Photo) | John Roe | [Github](https://github.com/) | [Portfolio](docs/team/johndoe.md)
![](https://via.placeholder.com/100.png?text=Photo) | Don Roe | [Github](https://github.com/) | [Portfolio](docs/team/johndoe.md)
| Display | Name | Github Profile | Portfolio |
|-------------------------------|:-------------:|:-----------------------------------------:|:---------------------------------:|
| ![](images/Arif-Photo.jpg) | Arif Khalid | [Github](https://github.com/arif-khalid) | [Portfolio](team/arif-khalid.md) |
| ![](images\Gan-Zhen-Yang.jpg) | Gan Zhen Yang | [Github](https://github.com/gan868611) | [Portfolio](team/gan868611.md) |
| ![](images/Benjamin.jpeg) | Benjamin Long | [Github](https://github.com/bawfen) | [Portfolio](team/bawfen.md) |
| ![](images/wenjun.jpg) | Woo Wen Jun | [Github](https://github.com/woowenjun99) | [Portfolio](team/woowenjun99.md) |
| ![](images/Jacob-Stein.jpg) | Jacob Stein | [Github](https://github.com/jacob-stein1) | [Portfolio](team/jacob-stein1.md) |
Loading