[CS2113-T13-1] MoneyMoover #26
Conversation
Add create account method
Update Duke & Expected
|
|
||
| ## Design & implementation | ||
| The following sequence diagram shows how the Exchange command works | ||
|  |
There was a problem hiding this comment.
Very detailed sequence diagram, but one point: is the spelling wrong? (underlined in red : BigDecimal instead of BigDecinmal)
docs/DeveloperGuide.md
Outdated
| is then extracted using saveMap, which filters out the rates for our supported currencies and performs type conversion. | ||
| The savedMap attribute of ExchangeRates is set to this filtered map, which is then passed to Forex via getExchangeRates. | ||
|
|
||
| If onFalire() is called, it means an unexpected error was encountered, such as losing Internet connection. |
There was a problem hiding this comment.
Is the spelling of the method wrong? (onFailure() instead of onFalire() )
|
|
||
| ## Non-Functional Requirements | ||
| ### Non-Functional Requirements |
There was a problem hiding this comment.
Please add more details in the next iteration of DG.
|
|
||
| {Give non-functional requirements} | ||
|
|
||
| ## Glossary | ||
| ### Glossary |
There was a problem hiding this comment.
Please add more details in the next iteration of DG.
docs/DeveloperGuide.md
Outdated
|
|
||
| ## Instructions for manual testing | ||
| ## Appendix: Instructions for manual testing |
There was a problem hiding this comment.
Please add more details in the next iteration of DG.
| functionality is to view the balance of a specific currency if the currency is specified, else view all the currencies | ||
| in the account. | ||
|
|
||
|  |
There was a problem hiding this comment.
Very detailed sequence diagram that showcases the balance feature
|
|
||
| The API of this component is specified in the `Ui.java`. | ||
|
|
||
|  |
There was a problem hiding this comment.
Is the text on the enumeration part of the image too flushed to the left? Should there be some padding instead?
| @@ -1,38 +1,335 @@ | |||
| # Developer Guide | |||
|
|
|||
There was a problem hiding this comment.
Very comprehensive sequence diagrams that show the flow of the application well.
| Only currency account which 0 balance can be deleted. | ||
|
|
||
| Given below is an example of the usage of this feature and the mechanism at each step | ||
|
|
There was a problem hiding this comment.
Should there be a space between the end of the text and the image? For Step 2 the image is in between the text which might not be ideal.
| rates from an online source. Future implementation will use an API to maintain up-to-date | ||
| exchange rates. | ||
|
|
||
| Exchange rate source: https://www.xe.com/currencyconverter/convert |
There was a problem hiding this comment.
Would it be better if this was in the form of a hyperlink instead? Such as:
Exchange Rate Link: [source](https://www.xe.com/currencyconverter/convert) which would give source.
Similar idea for the next subsection
| ## Acknowledgements | ||
|
|
||
| {list here sources of all reused/adapted ideas, code, documentation, and third-party libraries -- include links to the original source as well} |
There was a problem hiding this comment.
Could add more details in the next iteration of DG (also for the appendix sections).
* 'master' of https://github.com/AY2223S2-CS2113-T13-1/tp: Update the help documentation Update help message and error message for transaction command errors Update help message to include transaction command Update the help command Fix bug to only accept amount greater or equal to 0.01 Fix minor errors in sequence diagram Fix small error in transaction instantiation Remove unused import in Duke Add documentation in DG and UG for transactions
# Conflicts: # docs/UserGuide.md
Add default rates in case of API failure
Bug fix decimal rounding
* 'master' of https://github.com/AY2223S2-CS2113-T13-1/tp: test Fix bugs Remove duplicated code Fix typo Fix bug Update UG Use default exchange rates if API fails for any reason
An interface is used to define the functions for the Store so that a dummy store can be used in unit tests.
Add the ability to write to file.
* 'master' of https://github.com/AY2223S2-CS2113-T13-1/tp: Fix bug with LocalDateTimeAdapter Update API Key Fix logging message in TransactionManager Return early from save if there is an exception Add the ability to write to file. An interface is used to define the functions for the Store so that a dummy store can be used in unit tests.
Fix issue with balances being saved and loaded wrongly
* 'master' of https://github.com/AY2223S2-CS2113-T13-1/tp: Fix issue with balances being saved and loaded wrongly
Update the account list dg
* 'master' of https://github.com/AY2223S2-CS2113-T13-1/tp: Update the account list dg Update the parser for the dg Update the UI aspect of the class diagram Update the PPP Update the Balance UG Fix spacing error in withdraw example command Fix to help command formatting missing spaces Fix formatting in help command again Fix formatting in example help command Remove unnecessary spaces in UG Add further conditions for description in add and withdraw command Fix more standardisation errors in UG Fix standardisation of UG
# Conflicts: # docs/DeveloperGuide.md
This reverts commit ac8e9cb.
Update the Forex component
…nceCommand Arif khalid dg show rate and balance command
Add storage to dg
Update the ppp
MoneyMoover is a CLI application for managing and transferring international currencies, optimized for use via a Command Line Interface (CLI) while still having the features of other money management applications.