Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add egs view editor #710

Closed

Conversation

hcgallop
Copy link

@hcgallop hcgallop commented Apr 27, 2021

Add a new tab in egs_view that allows for editing and saving egsinp files for egs++.

The new code all over the egs++ library provide a structure by which an external library like egs_view can extract all of the input parameters. It's used for input validation, syntax highlighting, autocompletion, etc.

@rtownson rtownson added the gui label May 17, 2021
Townson and others added 2 commits May 19, 2021 14:15
Recent changes to egs_view were missing some necessary additions to the
ui file. These have been included, along with a couple minor changes.
Also set the compiler flags to use std=c++14 instead of std=c++11.
@rtownson rtownson self-assigned this Jun 10, 2021
@mainegra
Copy link
Contributor

@rtownson and @hcgallop could any of you provide a bit of information on what this pull request does? Is this coding needed by the egs_view GUI to allow editing certain portions of the input file?

@rtownson
Copy link
Collaborator

@rtownson and @hcgallop could any of you provide a bit of information on what this pull request does? Is this coding needed by the egs_view GUI to allow editing certain portions of the input file?

Yeah it's for the syntax highlighting and autocompletion. Geometries, sources, etc. are loaded as shared libraries to get this information about their inputs - I thought it made sense to keep the code about inputs right nearby where the inputs are processed, instead of coding it into egs_view (it would never get updated that way).

I'm still working on finishing this off and I'll add some documentation about it when I do so.

@rtownson
Copy link
Collaborator

rtownson commented Jul 4, 2022

Closing this PR and opening a new one, PR #885.

@rtownson rtownson closed this Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants