-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add release workflow #123
Conversation
The tool supports changing the log type to use the GitHub API - https://github.com/googleapis/release-please/blob/main/docs/customizing.md#changelog-types |
Ah nice. Do you know where this setting goes? It's not immediately obvious! EDIT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Who do we need to ping to get the correct tokens added to the repo secrets? If we do that before this is merged it should create a release PR! |
@legendecas any chance you could help with adding the token since you did it recently for the node-addon-api repo and can probably do it faster than me? |
done. Added |
Perfect, I think we just need a Github token now unless that has been added too? |
I think this should be ready. |
It is automatically generated, but if PRs are created with that token, workflows don't run on them. The
Githubs own docs also mention this:
Although now I'm looking at other PRs created by I'll merge this and it can be added later if it's a problem! |
So the PR has been created but the workflow hasn't run so there's no way to merge it! |
Ref #122
release-please.yml
is copied straight from here:https://github.com/nodejs/node-addon-api/blob/main/.github/workflows/release-please.yml
For this to actually work it needs Github credentials that can create PRs that trigger other workflows. The default GITHUB_TOKEN cannot do this.
https://github.com/googleapis/release-please-action?tab=readme-ov-file#github-credentials
We also need an NPM token added to the secrets so it can publish.