Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable GitHub fine-grained personal access tokens #891

Closed
6 tasks
legendecas opened this issue Jul 3, 2024 · 2 comments
Closed
6 tasks

Enable GitHub fine-grained personal access tokens #891

legendecas opened this issue Jul 3, 2024 · 2 comments

Comments

@legendecas
Copy link
Member

legendecas commented Jul 3, 2024

To allow creating GitHub fine-grained personal access tokens, an organization-level enrollment must be performed at https://github.com/organizations/nodejs/settings/personal-access-tokens-onboarding.

The classic GitHub personal access tokens are not restricted to a particular set of repositories, while the new GitHub fine-grained token allows being restricted to a particular repository with specific permissions to reduce security scopes. Thus I'd request to enable fine-grained tokens for the organization.

The options for the enrollment include:

  1. Restrict access via fine-grained personal access tokens
    By default, fine-grained personal access tokens cannot access content owned by your organization via the Public API or Git. This includes both public and private resources such as repositories.
  • Allow access via fine-grained personal access tokens
    API and Git access will be allowed using approved organization member's fine-grained personal access tokens
  • Restrict access via fine-grained personal access tokens
    Organization members will not be allowed to access your organization using a fine-grained personal access token
  1. Require approval of fine-grained personal access tokens
    Access requests by organization members can be subject to review by administrator before approval.
  • Require administrator approval
    All access requests by organization members to this organization must be approved before the token is usable.
  • Do not require administrator approval
    Tokens requested for this organization will work immediately, and organization members are not required to provide a justification when creating the token.
  1. Restrict access via personal access tokens (classic)
    By default, personal access tokens (classic) can access content owned by your organization via the GitHub API or Git over HTTPS. This includes both public and private resources such as repositories.
  • Allow access via personal access tokens (classic)
    API and Git access will be allowed using an organization member's personal access token (classic)
  • Restrict access via personal access tokens (classic)
    Organization members will not be allowed to access your organization using a personal access token (classic)

I believe we have tools like @node-core/utils that already use classic personal access tokens, so they must be allowed to access the organization's resources. And given that personal access token creations and accesses do not require approval, my suggestions would be:

  1. allow fine-grained tokens, 2) do not require approval, 3) allow access via classic personal access tokens.

Refs: nodejs/import-in-the-middle#123 (comment)

@AbhiPrasad
Copy link

Given this blocks the release here nodejs/import-in-the-middle#135 (comment), is there a timeline for this issue?

@legendecas
Copy link
Member Author

With +5 on the issue and 5 days since then, I've enrolled the org to the fine-grained access tokens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants