Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pinned IREE version to 20241206. #778

Merged
merged 8 commits into from
Jan 7, 2025

Conversation

ScottTodd
Copy link
Member

Note that the mobilenet program being tested was miscompiling and producing different output compared to onnxruntime prior to iree-org/iree@d48071d.

Note that the mobilenet program being tested was miscompiling and producing different output compared to onnxruntime prior to iree-org/iree@d48071d.
@ScottTodd ScottTodd marked this pull request as ready for review January 7, 2025 21:49
@ScottTodd ScottTodd requested a review from stbaione January 7, 2025 21:59
Copy link
Contributor

@stbaione stbaione left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ScottTodd ScottTodd enabled auto-merge (squash) January 7, 2025 22:09
@ScottTodd ScottTodd disabled auto-merge January 7, 2025 22:11
@ScottTodd
Copy link
Member Author

ASan tests are taking a suspiciously long time too: https://github.com/nod-ai/shark-ai/actions/runs/12660107279/job/35280645767?pr=778

@ScottTodd
Copy link
Member Author

ASan tests are taking a suspiciously long time too: https://github.com/nod-ai/shark-ai/actions/runs/12660107279/job/35280645767?pr=778

Argh! The ASan workflow is using a dependency cache that was not invalidated, so it installed the older version of the packages and had the same error/hang as the unit tests.

@ScottTodd ScottTodd merged commit 126330d into nod-ai:main Jan 7, 2025
25 of 28 checks passed
@ScottTodd ScottTodd deleted the bump-iree-20241206 branch January 7, 2025 23:05
monorimet pushed a commit that referenced this pull request Jan 8, 2025
Note that the mobilenet program being tested was miscompiling and
producing different output compared to onnxruntime prior to
iree-org/iree@d48071d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants