Skip to content

Commit

Permalink
Bump pinned IREE version to 20241206. (#778)
Browse files Browse the repository at this point in the history
Note that the mobilenet program being tested was miscompiling and
producing different output compared to onnxruntime prior to
iree-org/iree@d48071d.
  • Loading branch information
ScottTodd authored and eagarvey-amd committed Jan 8, 2025
1 parent f26f4d7 commit 9f1383a
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 6 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ci_linux_x64_asan-libshortfin.yml
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ jobs:
uses: actions/cache/restore@0c45773b623bea8c8e75f6c82b208c3cf94ea4f9 # v4.0.2
with:
path: ${{ env.PYENV_ROOT }}
key: ${{ runner.os }}-python-deps-${{ hashFiles('shortfin/requirements-tests.txt') }}-v${{ env.CACHE_DEPS_VER }}
key: ${{ runner.os }}-python-deps-${{ hashFiles('shortfin/requirements-tests.txt', 'requirements-iree-pinned.txt') }}-v${{ env.CACHE_DEPS_VER }}

- name: Restore Python ASan cache
id: cache-python-asan
Expand Down Expand Up @@ -152,4 +152,4 @@ jobs:
working-directory: ${{ env.LIBSHORTFIN_DIR }}
run: |
eval "$(pyenv init -)"
pytest -s
pytest -s --durations=10 --timeout=30
6 changes: 3 additions & 3 deletions requirements-iree-pinned.txt
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
# Keep these versions synced with SHORTFIN_IREE_GIT_TAG in shortfin/CMakeLists.txt
--pre
--find-links https://iree.dev/pip-release-links.html
iree-base-compiler==3.1.0rc20241204
iree-base-runtime==3.1.0rc20241204
iree-base-compiler==3.1.0rc20241206
iree-base-runtime==3.1.0rc20241206

# TODO(#760): include iree-turbine in this requirements file too?
# iree-turbine==3.1.0rc20241205
# iree-turbine==3.1.0rc20241206
5 changes: 4 additions & 1 deletion shortfin/tests/invocation/mobilenet_program_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,10 @@ async def assert_mobilenet_ref_output(device, device_output):
absmean = functools.reduce(
lambda x, y: x + abs(y) / len(flat_output), flat_output, 0.0
)
assert absmean == pytest.approx(5.01964943873882)
# Note: this value was just copied from a sample run of the test.
# Comparison against a reference backend for this model is tested upstream
# in https://github.com/iree-org/iree-test-suites/tree/main/onnx_models.
assert absmean == pytest.approx(0.81196929)


# Tests that a single invocation on a single fiber works.
Expand Down

0 comments on commit 9f1383a

Please sign in to comment.