Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update user docs for running llm server + upgrade gguf to 0.11.0 #676

Merged
merged 5 commits into from
Dec 12, 2024

Conversation

stbaione
Copy link
Contributor

Description

Did a pass through and made updates + fixes to the user docs for e2e_llama8b_mi300x.md.

  1. Update install instructions for shark-ai
  2. Update nightly install instructions for shortfin and sharktank
  3. Update paths for model artifacts to ensure they work with llama3.1-8b-fp16-instruct
  4. Remove steps to write edited config. No longer needed after Make config.json consistent between shortfin and sharktank #487

Added back sentencepiece as a requirement for sharktank. Not having it caused export_paged_llm_v1 to break when installing nightly:

ModuleNotFoundError: No module named 'sentencepiece'

This was obfuscated when building from source, because shortfin includes sentencepiece in requirements-tests.txt.

Add back `sentencepiece` as requirement for `sharktank` to enable `export_paged_llm_v1`
@stbaione stbaione requested a review from ScottTodd December 11, 2024 16:33
docs/shortfin/llm/user/e2e_llama8b_mi300x.md Outdated Show resolved Hide resolved
sharktank/requirements.txt Outdated Show resolved Hide resolved
@stbaione stbaione changed the title Update user docs for running llm server Update user docs for running llm server + upgrade gguf to 0.11.0 Dec 12, 2024
@stbaione stbaione requested review from ScottTodd and marbre December 12, 2024 18:08
Update `stable` and `nightly` installation instructs,
Only set lower-bound for `gguf`
@stbaione stbaione requested a review from ScottTodd December 12, 2024 21:48
Copy link
Member

@ScottTodd ScottTodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went through this full document earlier today. Typing up some feedback in an issue to follow up.

@ScottTodd
Copy link
Member

I went through this full document earlier today. Typing up some feedback in an issue to follow up.

#691

@stbaione stbaione merged commit f7d2681 into nod-ai:main Dec 12, 2024
8 checks passed
@marbre
Copy link
Collaborator

marbre commented Dec 13, 2024

Added back sentencepiece as a requirement for sharktank. Not having it caused export_paged_llm_v1 to break when installing nightly:

ModuleNotFoundError: No module named 'sentencepiece'

This was obfuscated when building from source, because shortfin includes sentencepiece in requirements-tests.txt.

This made it into the commit description. If the PR content changes, please remember to update the PR description or at least the squash commit message accordingly.

IanNod pushed a commit to IanNod/SHARK-Platform that referenced this pull request Dec 17, 2024
nod-ai#676)

# Description

Did a pass through and made updates + fixes to the user docs for
`e2e_llama8b_mi300x.md`.

1. Update install instructions for `shark-ai`
2. Update nightly install instructions for `shortfin` and `sharktank`
3. Update paths for model artifacts to ensure they work with
`llama3.1-8b-fp16-instruct`
4. Remove steps to `write edited config`. No longer needed after nod-ai#487 

Added back `sentencepiece` as a requirement for `sharktank`. Not having
it caused `export_paged_llm_v1` to break when installing nightly:

```text
ModuleNotFoundError: No module named 'sentencepiece'
```

This was obfuscated when building from source, because `shortfin`
includes `sentencepiece` in `requirements-tests.txt`.
monorimet pushed a commit that referenced this pull request Jan 8, 2025
#676)

# Description

Did a pass through and made updates + fixes to the user docs for
`e2e_llama8b_mi300x.md`.

1. Update install instructions for `shark-ai`
2. Update nightly install instructions for `shortfin` and `sharktank`
3. Update paths for model artifacts to ensure they work with
`llama3.1-8b-fp16-instruct`
4. Remove steps to `write edited config`. No longer needed after #487 

Added back `sentencepiece` as a requirement for `sharktank`. Not having
it caused `export_paged_llm_v1` to break when installing nightly:

```text
ModuleNotFoundError: No module named 'sentencepiece'
```

This was obfuscated when building from source, because `shortfin`
includes `sentencepiece` in `requirements-tests.txt`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants