[sharktank] Depend on sentencepiece
#687
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While `gguf`'s `pyproject.toml` lists `sentencepiece` as a dependency (https://github.com/ggerganov/llama.cpp/blob/a07c32ea54850c989f0ef6989da5b955b77b7172/pyproject.toml#L20), the package does not get pulled in when installing gguf via `uv pip` or `pip`. However, without the package the sanity test `python -c "from sharktank import ops; print('Sanity check passed')"`, documented in https://github.com/nod-ai/shark-ai/blob/main/docs/nightly_releases.md#quickstart---sharktank fails.
ScottTodd
reviewed
Dec 12, 2024
Comment on lines
7
to
+8
| # Needed for newer gguf versions (TODO: remove when gguf package includes this) | ||
| # sentencepiece>=0.1.98,<=0.2.0 | ||
| sentencepiece>=0.1.98,<=0.2.0 |
There was a problem hiding this comment.
See response #676 (comment). v0.11.0 released an hour ago, which has sentecepiece included as a dep
There was a problem hiding this comment.
Upgrading gguf to 0.11.0 and removing sentencepiece dep in #676
There was a problem hiding this comment.
Ah, I saw the tag for 0.11.0 but there was no whl on PyPI and the project.toml looked identical. Thanks for updating!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While
gguf'spyproject.tomllistssentencepieceas a dependency (https://github.com/ggerganov/llama.cpp/blob/a07c32ea54850c989f0ef6989da5b955b77b7172/pyproject.toml#L20), the package does not get pulled in when installing gguf viauv piporpip. However, without the package the sanity testpython -c "from sharktank import ops; print('Sanity check passed')", documented in https://github.com/nod-ai/shark-ai/blob/main/docs/nightly_releases.md#quickstart---sharktank, fails.