Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no longer need to support pre-c++11 build systems, let newer systems use a newer C++ standard #18

Merged
merged 2 commits into from
Sep 1, 2023

Conversation

lucasw
Copy link
Contributor

@lucasw lucasw commented Aug 30, 2023

I assume this is the case, otherwise if statements are needed in the cmake to build in later systems using c++17 or simi/lar, for instance with c++11 building on Ubuntu 22.04 results in errors like this:

/usr/include/log4cxx/boost-std-configuration.h:10:18: error: ‘shared_mutex’ in namespace ‘std’ does not name a type
   10 |     typedef std::shared_mutex shared_mutex;

@Timple
Copy link
Member

Timple commented Aug 31, 2023

Please not that this repository is only a copy of the official driver. So if you're compiling from source, you might want the official one from their downloads page.

That being said, I don't have anything against this change.

@lucasw
Copy link
Contributor Author

lucasw commented Aug 31, 2023

If this is ok to merge please do.

Is there an effort to incorporate changes from new official releases and combining them with commits here? Understandable if it isn't a priority for anyone, I just want something that works with the sensors I have and want the least effort way to setup on regular systems and into my github action builds (like a public github repo).

There are a lot of outdated links (some of them a result of the acquisition by Movella) so I'm not sure where the official driver is. I looked a little on https://www.movella.com/support/software-documentation, maybe it's in Download MT Software Suite 2022.0 for Linux.

@Timple
Copy link
Member

Timple commented Sep 1, 2023

Is there an effort to incorporate changes from new official releases and combining them with commits here?

I believe we opened some tickets for trivial fixes in the past, but without any luck. So no.
I'm still curious why you compile manually if you have apt-installable packages available 🙂

@Timple Timple merged commit 701d824 into nobleo:master Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants