Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#454] Use appStoreConnectApiKey() for fastlane match #540

Merged
merged 5 commits into from
Dec 4, 2023
Merged

[#454] Use appStoreConnectApiKey() for fastlane match #540

merged 5 commits into from
Dec 4, 2023

Conversation

nkhanh44
Copy link
Contributor

@nkhanh44 nkhanh44 commented Oct 30, 2023 •
edited
Loading

What happened 👀

  • Added apiKey for match() and registerDevice().

Insight 📝

  • Use .env to store secrets in the local
KEY_ID=""
ISSUER_ID=""
KEY=""

Proof Of Work 📹

Before:

Screenshot 2023-10-29 at 19 10 08

After: no need to ask for login using username and password

Screenshot 2023-10-29 at 22 07 22

@nkhanh44 nkhanh44 self-assigned this Oct 30, 2023
@nkhanh44 nkhanh44 marked this pull request as ready for review October 30, 2023 10:13
markgravity
markgravity approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@markgravity markgravity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 👍

@blyscuit blyscuit added this to the 4.10.0 milestone Nov 1, 2023
@nkhanh44 nkhanh44 force-pushed the feature/454-use-appStore-ConnectApiKey branch from 72545b1 to 0525f8a Compare November 6, 2023 05:41
@nkhanh44 nkhanh44 force-pushed the feature/454-use-appStore-ConnectApiKey branch from 0525f8a to dd1965a Compare November 20, 2023 07:21
vnntsu
vnntsu reviewed Nov 23, 2023
View reviewed changes
fastlane/Helpers/Match.swift Outdated
@@ -27,6 +27,7 @@ enum Match {
type: type.match,
readonly: .userDefined(!isForce),
appIdentifier: [environment.bundleId],
apiKey: .userDefined(Constant.apiKey),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we do not recommend to use apiKey for match like that. Or in case we must do it, please check isForce too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added checking isForce at a3d7e1f 🙏

fastlane/Fastfile.swift Show resolved Hide resolved
@nkhanh44 nkhanh44 requested a review from vnntsu November 30, 2023 04:51
@blyscuit blyscuit added this pull request to the merge queue Dec 4, 2023
Merged via the queue into develop with commit a9b5099 Dec 4, 2023
4 checks passed
@blyscuit blyscuit deleted the feature/454-use-appStore-ConnectApiKey branch December 4, 2023 10:45
@blyscuit blyscuit mentioned this pull request Dec 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markgravity markgravity markgravity approved these changes

@blyscuit blyscuit blyscuit approved these changes

@suho suho Awaiting requested review from suho suho is a code owner

@minhnimble minhnimble Awaiting requested review from minhnimble minhnimble is a code owner

@nmint8m nmint8m Awaiting requested review from nmint8m nmint8m is a code owner

@phongvhd93 phongvhd93 Awaiting requested review from phongvhd93 phongvhd93 is a code owner

@ducbm051291 ducbm051291 Awaiting requested review from ducbm051291 ducbm051291 is a code owner

@Shayokh144 Shayokh144 Awaiting requested review from Shayokh144 Shayokh144 is a code owner

@Thieurom Thieurom Awaiting requested review from Thieurom Thieurom is a code owner

@vnntsu vnntsu Awaiting requested review from vnntsu vnntsu is a code owner

Assignees

@nkhanh44 nkhanh44

Labels
type : feature
Projects
None yet
Milestone
4.10.0
Development

Successfully merging this pull request may close these issues.
4 participants
@nkhanh44 @blyscuit @vnntsu @markgravity