New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release - 4.10.0 #550

Merged

blyscuit merged 40 commits into main from release/4.10.0

Jan 2, 2024

Collaborator

blyscuit commented Dec 21, 2023 •

edited

Loading

https://github.com/nimblehq/ios-templates/milestone/25

Features

Chores

Bugs

[#519] Fix: Test run failed for not finding host application for staging scheme #544

Contents

[#541] Update the iOS template project structure to reflect the new modules #545

blyscuit and others added 30 commits

October 5, 2023 13:01


          [#528] No time-out keychain

32aa23b


          [#528] Make timeout 1.3 days

b581840


          [#530] Add SwiftUI file organization wiki

d9d2f44


          [#530] Fix build Rx

5304d62


          [#530] Fix build


          [#522] Use FIREBASE_SERVICE_ACCOUNT instead of FIREBASE_TOKEN

fa8b0d7


          [#522] Use FIREBASE_SERVICE_ACCOUNT instead of FIREBASE_TOKEN

ce963ca


          [#482] Repace Podfile hard-code version with {TARGET_VERSION}

39e917c


          [#521] Update norio-nomura/action-swiftlint to latest version 3.2.1

57834b8


          [#521] Update norio-nomura/action-swiftlint to master branch

10c83d9


          Merge pull request #529 from nimblehq/chore/#528-keychain-no-timeout

ffca168

[#528] Update Default timeout for Keychain to `no time-out`


          Merge pull request #532 from nimblehq/chore/#530-standard-file-organi…

54c98ee

…zation-swiftui

[#530] Update Standard File Organization Wiki


          Merge pull request #538 from nimblehq/feature/509-pod-file-version-ma…

a18a2ea

…tch-project

[#509] Minimum ios version does not match the set version when create project with template


          Merge pull request #533 from nimblehq/feature/#522-google-service-acc…

6809fca

…ount-firebase

[#522] Replace Firebase Token with Google Service Account


          [#521] Update Mark's approach

a571c23


          [#519] Updae configuration

e27fa3a


          Merge pull request #539 from nimblehq/chore/521-update-latest-swiftli…

9bae9c0

…nt-action

[#521] [Chore]  Update SwiftLint in GitHub Workflows to the newest version


          [#454] Add apiKey

bf74dd1


          [#454] Add variables to env

181fbe3


          [#454] Rename

0c5017b


          [#454] Update keys

dd1965a


          [#519] Remove product name from xcconfig

1b86e63


          Fix lints

8de90be


          [#454] Check isForce for apiKey in syncCodeSigning

a3d7e1f


          Merge pull request #544 from nimblehq/fix/519-update-display-name

a268748

[#519] Fix: Test run failed for not finding host application for staging scheme


          Merge pull request #540 from nimblehq/feature/454-use-appStore-Connec…

a9b5099

…tApiKey

[#454] Use appStoreConnectApiKey() for fastlane match


          [#498] Update Script: SetUpCICDService to ask for runner type

7db4dcb

Wwe create 2 folders for each runner type with the same workflows but different runs-on. When the developer chooses a runner type, the chosen type will be copied to the workflow directory.


          [#498] Create Enum for gifhub runner type

4ec71c2


          [#498] Remove project workflows and self hosted project workflows in …

cae4b35

…case CICD using bitrise or codemagic


          [#498] Update case .none

70932c0

phongvhd93 and others added 9 commits

December 15, 2023 14:09


          [#349] Create target

38fd30b


          [#349] Create modules for Domain and Data layer

547acd5


          [#349] remove unncessary constant

517900e


          [#349] Rename makeFramework to frameworkTargets

4fccd41


          [#349] Improve the duplicated codes

c86637e


          Merge pull request #536 from nimblehq/feature/#349-modular-data-and-d…

1897bcc

…omain

[#349] Add the domain and data layers as targets (modules) in the project


          [#541] Update Standard File Organization

c9675af


          Merge pull request #545 from nimblehq/feature/#541-update-doc-for-new…

505ca73

…-modules

[#541] Update the iOS template project structure to reflect the new modules


          Merge pull request #543 from nimblehq/feature/498-add-option-github-s…

11790f1

…elf-hosted-while-generating-project

[#498] Add option: github-self-hosted while generating the project

blyscuit self-assigned this

blyscuit added the type : release label

blyscuit added this to the 4.10.0 milestone

blyscuit marked this pull request as ready for review

December 21, 2023 09:18

blyscuit requested review from suho, markgravity, minhnimble, nmint8m, phongvhd93, vnntsu, ducbm051291, Shayokh144, Thieurom and nkhanh44 as code owners

December 21, 2023 09:18

ducbm051291 approved these changes

View reviewed changes

nkhanh44 approved these changes

View reviewed changes

minhnimble approved these changes

View reviewed changes

suho approved these changes

View reviewed changes

Member

suho left a comment

LGTM

markgravity approved these changes

View reviewed changes

blyscuit merged commit 75d72b7 into main

2 checks passed

blyscuit deleted the release/4.10.0 branch

January 2, 2024 04:30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

minhnimble minhnimble approved these changes

nkhanh44 nkhanh44 approved these changes

ducbm051291 ducbm051291 approved these changes

suho suho approved these changes

markgravity markgravity approved these changes

nmint8m Awaiting requested review from nmint8m nmint8m is a code owner

phongvhd93 Awaiting requested review from phongvhd93 phongvhd93 is a code owner

vnntsu Awaiting requested review from vnntsu vnntsu is a code owner

Shayokh144 Awaiting requested review from Shayokh144 Shayokh144 is a code owner

Thieurom Awaiting requested review from Thieurom Thieurom is a code owner

Labels