Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the credo rule #267

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

Improve the credo rule #267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1961966
Improve the credo rule
andyduong1920 Sep 22, 2022
18b8765
Improve the rules
andyduong1920 Sep 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .credo.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,8 +165,7 @@
{Credo.Check.Readability.StrictModuleLayout,
[
order:
~w/shortdoc moduledoc behaviour use import alias require module_attribute defstruct callback public_fun private_fun/a,
ignore: ~w/callback_impl/a
~w/shortdoc moduledoc behaviour use import alias require module_attribute type typep defstruct callback public_macro private_macro callback_impl public_fun private_fun/a
]},
{Credo.Check.Consistency.MultiAliasImportRequireUse, []},
{Credo.Check.Consistency.UnusedVariableNames, []},
Expand Down
3 changes: 1 addition & 2 deletions priv/templates/nimble_template/.credo.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,8 +159,7 @@
{Credo.Check.Readability.StrictModuleLayout,
[
order:
~w/shortdoc moduledoc behaviour use import alias require module_attribute defstruct callback public_fun private_fun/a,
ignore: ~w/callback_impl/a
~w/shortdoc moduledoc behaviour use import alias require module_attribute type typep defstruct callback public_macro private_macro callback_impl public_fun private_fun/a
]},
{Credo.Check.Consistency.MultiAliasImportRequireUse, []},
{Credo.Check.Consistency.UnusedVariableNames, false},
Expand Down