Improve the credo rule #267
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyduong1920
force-pushed
the
chore/improve-credo
branch
from
38215a8 to
18b8765
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What happened 👀
Improve the rules base on #256
Insight 📝
On [Chore] Update credo config to support check private vs public functions order #256 we introduce the
public and privatemethods only, without thetype/typesso when I introduced only these rules to the client project, we have some weird order likeSo I spent time improving the rule again on the client project and bringing it back to our template
Refer: https://github.com/rrrene/credo/blob/master/lib/credo/check/readability/strict_module_layout.ex#L29
Proof Of Work 📹
The test is passed
On a client project