Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release] 3.25.0 #550

Merged
merged 31 commits into from
Oct 31, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
5eb9b25
[Chore] Bump version to 3.25.0
ryan-conway Oct 3, 2023
8450038
Merge pull request #524 from nimblehq/chore/bump-version-to-3.25.0
ryan-conway Oct 4, 2023
a7ab8fc
[#502] Remove bump xml sample version from workflow
ryan-conway Oct 5, 2023
0e49800
[#500] Remove unnecessary token from checkout action
ryan-conway Oct 5, 2023
031ff62
[#500] Update checkout action version and name for consistency
ryan-conway Oct 5, 2023
5cc995b
[#521] Fix bump version workflow in .cicdtemplate
ryan-conway Oct 6, 2023
cbfa993
Merge pull request #532 from nimblehq/chore/500-the-checkout-step-in-…
ryan-conway Oct 6, 2023
bf97594
Merge pull request #537 from nimblehq/bug/521-fix-the-bump_version-te…
ryan-conway Oct 9, 2023
1b3d92e
Merge pull request #527 from nimblehq/chore/502-remove-bump-version-x…
ryan-conway Oct 9, 2023
b17f703
[#538] Update all workflows to use Java 17
ryan-conway Oct 9, 2023
082ad3e
[#538] Remove duplicate set up JDK steps
ryan-conway Oct 11, 2023
eb30932
Merge pull request #540 from nimblehq/bug/538-fix-the-template-workfl…
ryan-conway Oct 11, 2023
d50e45b
[#503] Deprecate xml templates
thiennguyen0196 Sep 14, 2023
f4c1579
[#503] Update ci workflow
thiennguyen0196 Sep 14, 2023
4b801c2
[#503] Update ci workflow
thiennguyen0196 Sep 14, 2023
f4b1cfd
[#503] Update new project script prefix xml template name
thiennguyen0196 Sep 14, 2023
90ee187
[#503] Update readme
thiennguyen0196 Sep 14, 2023
538c71d
[#503] Update danger template xml
thiennguyen0196 Sep 14, 2023
f083e2d
[#503] Update CI/CD workflow to remove xml template and rename rxjava…
thiennguyen0196 Oct 9, 2023
81f90a4
[#503] Update script to remove generating xml project script
thiennguyen0196 Oct 9, 2023
8bd2c87
[#503] Update readme
thiennguyen0196 Oct 9, 2023
10e01c3
[#503] Make compose becomes default template
thiennguyen0196 Oct 13, 2023
ed83e97
[#503] Update README
thiennguyen0196 Oct 13, 2023
ce05d6b
Merge pull request #519 from nimblehq/chore/503-deprecate-xml-template
ryan-conway Oct 16, 2023
f78d181
[#535] Update state flow to use asStateFlow
kaungkhantsoe Oct 19, 2023
06dc8f5
[#543] Add default spacing dimensions
hoangnguyen92dn Oct 19, 2023
590332a
Merge pull request #544 from nimblehq/feature/543-add-default-spacing…
ryan-conway Oct 20, 2023
1d51e5d
[#535] Update state flow to use asStateFlow in base viewmodel classes
kaungkhantsoe Oct 20, 2023
b90cbe3
Merge pull request #545 from nimblehq/feature/535-add-asstateflow-to-…
ryan-conway Oct 23, 2023
f2123c6
[#462] Add concurrency for cicd
kaungkhantsoe Oct 23, 2023
7a75d19
Merge pull request #546 from nimblehq/feature/462-add-support-for-con…
ryan-conway Oct 25, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
16 changes: 8 additions & 8 deletions .cicdtemplate/.github/workflows/bump_version.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,21 +8,21 @@ on:
required: true
type: string

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

jobs:
bump_version:
name: Bump version
runs-on: ubuntu-latest
steps:
- name: Checkout the latest code
uses: actions/checkout@v3
with:
token: ${{ secrets.GITHUB_TOKEN }}
- name: Checkout source code
uses: actions/checkout@v4

- name: Bump version name
uses: chkfung/[email protected]
with:
gradlePath: app/build.gradle.kts
versionName: ${{ github.event.inputs.newVersion }}
run: |
perl -i -pe 's/ANDROID_VERSION_NAME =(.*)$/ANDROID_VERSION_NAME = "${{ github.event.inputs.newVersion }}"/g' buildSrc/src/main/java/Versions.kt

- name: Create pull request
uses: peter-evans/create-pull-request@v4
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,19 +13,19 @@ jobs:
runs-on: ubuntu-latest
timeout-minutes: 30
steps:
- name: Set up JDK 11
- name: Set up JDK 17
uses: actions/setup-java@v3
with:
distribution: 'temurin'
java-version: '11'
java-version: '17'

- name: Set up timezone
uses: zcong1993/setup-timezone@master
with:
timezone: Asia/Bangkok

- name: Checkout source code
uses: actions/checkout@v2.3.2
uses: actions/checkout@v4

- name: Cache Gradle
uses: actions/cache@v2
Expand Down
10 changes: 7 additions & 3 deletions .cicdtemplate/.github/workflows/review_pull_request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,20 +4,24 @@ on:
pull_request:
types: [ opened, edited, reopened, synchronize ]

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

jobs:
review_pull_request:
name: Review pull request
runs-on: ubuntu-latest
timeout-minutes: 30
steps:
- name: Set up JDK 11
- name: Set up JDK 17
uses: actions/setup-java@v3
with:
distribution: 'temurin'
java-version: '11'
java-version: '17'

- name: Checkout source code
uses: actions/checkout@v2.3.2
uses: actions/checkout@v4

- name: Cache Gradle
uses: actions/cache@v2
Expand Down
10 changes: 7 additions & 3 deletions .cicdtemplate/.github/workflows/run_detekt_and_unit_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,25 +10,29 @@ on:
- develop
- 'release/**'

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

jobs:
run_detekt_and_unit_tests:
name: Run Detekt and unit tests
runs-on: ubuntu-latest
timeout-minutes: 30
steps:
- name: Set up JDK 11
- name: Set up JDK 17
uses: actions/setup-java@v3
with:
distribution: 'temurin'
java-version: '11'
java-version: '17'

- name: Set up timezone
uses: zcong1993/setup-timezone@master
with:
timezone: Asia/Bangkok

- name: Checkout source code
uses: actions/checkout@v2.3.2
uses: actions/checkout@v4

- name: Cache Gradle
uses: actions/cache@v2
Expand Down
14 changes: 6 additions & 8 deletions .github/workflows/bump_version.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,24 +8,22 @@ on:
required: true
type: string

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

jobs:
bump_version:
name: Bump version
runs-on: ubuntu-latest
steps:
- name: Checkout the latest code
uses: actions/checkout@v3
with:
token: ${{ secrets.GITHUB_TOKEN }}
- name: Checkout source code
uses: actions/checkout@v4

- name: Bump version script
run: |
perl -i -pe 's/^(templateScriptVersion=(.*))$/"templateScriptVersion=${{ github.event.inputs.newVersion }}"/e' version.properties

- name: Bump version XML
run: |
perl -i -pe 's/ANDROID_VERSION_NAME =(.*)$/ANDROID_VERSION_NAME = "${{ github.event.inputs.newVersion }}"/g' sample-xml/buildSrc/src/main/java/Versions.kt

- name: Bump version Compose
run: |
perl -i -pe 's/ANDROID_VERSION_NAME =(.*)$/ANDROID_VERSION_NAME = "${{ github.event.inputs.newVersion }}"/g' sample-compose/buildSrc/src/main/java/Versions.kt
Expand Down
8 changes: 6 additions & 2 deletions .github/workflows/draft-new-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,19 @@ on:
permissions:
contents: read

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

jobs:
draft_new_release:
permissions:
contents: write
runs-on: ubuntu-latest
timeout-minutes: 30
steps:
- name: Checkout code
uses: actions/checkout@v2
- name: Checkout source code
uses: actions/checkout@v4

- name: Install Kscript
run: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/publish_docs_to_wiki.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ jobs:
runs-on: ubuntu-latest
timeout-minutes: 30
steps:
- name: Check out the repository
uses: actions/checkout@v3
- name: Checkout source code
uses: actions/checkout@v4
with:
ref: ${{ github.head_ref }}

Expand Down
30 changes: 7 additions & 23 deletions .github/workflows/review_pull_request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,21 +4,25 @@ on:
pull_request:
types: [ opened, edited, reopened, synchronize ]

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

jobs:
review_pull_request:
name: Review pull request
runs-on: ubuntu-latest
timeout-minutes: 30
environment: template-compose
steps:
- name: Set up JDK 11
- name: Set up JDK 17
uses: actions/setup-java@v3
with:
distribution: 'temurin'
java-version: '11'
java-version: '17'

- name: Checkout source code
uses: actions/checkout@v2.3.2
uses: actions/checkout@v4

- name: Cache Gradle
uses: actions/cache@v2
Expand All @@ -31,28 +35,8 @@ jobs:
restore-keys: |
${{ runner.os }}-gradle-

# template-xml

- name: Run Detekt on template-xml
working-directory: ./template-xml
run: ./gradlew detekt

- name: Run Android Lint on template-xml
working-directory: ./template-xml
run: ./gradlew lint

- name: Run unit tests with Kover on template-xml
working-directory: ./template-xml
run: ./gradlew koverXmlReport

# template-compose

- name: Set up JDK 17
uses: actions/setup-java@v3
with:
distribution: 'temurin'
java-version: '17'

- name: Run Detekt on template-compose
working-directory: ./template-compose
run: ./gradlew detekt
Expand Down
56 changes: 5 additions & 51 deletions .github/workflows/run_detekt_and_unit_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,18 @@ name: Run Detekt and unit tests

on: push

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

jobs:
run_detekt_and_unit_tests:
name: Run Detekt and unit tests
runs-on: ubuntu-latest
timeout-minutes: 30
steps:
- name: Checkout source code
uses: actions/checkout@v2.3.2
uses: actions/checkout@v4

- name: Cache Gradle
uses: actions/cache@v2
Expand Down Expand Up @@ -50,56 +54,6 @@ jobs:
name: CodeCoverageReportsTemplateCompose
path: template-compose/app/build/reports/kover/

# template-xml

- name: Set up JDK 11
uses: actions/setup-java@v3
with:
distribution: 'temurin'
java-version: '11'

- name: Run Detekt on template-xml
working-directory: ./template-xml
run: ./gradlew detekt

- name: Archive Detekt reports on template-xml
uses: actions/upload-artifact@v3
with:
name: DetektReportsTemplateXML
path: template-xml/build/reports/detekt/

- name: Run unit tests with Kover on template-xml
working-directory: ./template-xml
run: ./gradlew koverHtmlReport

- name: Archive code coverage reports on template-xml
uses: actions/upload-artifact@v3
with:
name: CodeCoverageReportsTemplateXML
path: template-xml/app/build/reports/kover/

# sample-xml

- name: Run Detekt on sample-xml
working-directory: ./sample-xml
run: ./gradlew detekt

- name: Archive Detekt reports on sample-xml
uses: actions/upload-artifact@v3
with:
name: DetektReportsTemplateXML
path: sample-xml/build/reports/detekt/

- name: Run unit tests with Kover on sample-xml
working-directory: ./sample-xml
run: ./gradlew koverHtmlReport

- name: Archive code coverage reports on sample-xml
uses: actions/upload-artifact@v3
with:
name: CodeCoverageReportsTemplateXML
path: sample-xml/app/build/reports/kover/

# sample-compose

- name: Run Detekt on sample-compose
Expand Down
20 changes: 7 additions & 13 deletions .github/workflows/verify_newproject_script.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,20 +5,24 @@ on:
types: [ opened, reopened, synchronize ]
branches: [ develop ]

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

jobs:
verify_newproject_script:
name: Verify newproject script
runs-on: ubuntu-latest
timeout-minutes: 30
steps:
- name: Set up JDK 11
- name: Set up JDK 17
uses: actions/setup-java@v3
with:
distribution: 'temurin'
java-version: '11'
java-version: '17'

- name: Checkout source code
uses: actions/checkout@v2.3.2
uses: actions/checkout@v4

- name: Cache Gradle
uses: actions/cache@v2
Expand All @@ -40,16 +44,6 @@ jobs:
sdk install kscript $kscriptVersion
echo $PATH >> $GITHUB_PATH

- name: Verify generating new project from template-xml
working-directory: scripts
run: kscript new_project.kts package-name=co.myxmlproject.example app-name="My XML Project" template=xml

- name: Set up JDK 17
uses: actions/setup-java@v3
with:
distribution: 'temurin'
java-version: '17'

- name: Verify generating new project from template-compose
working-directory: scripts
run: kscript new_project.kts package-name=co.mycomposeproject.example app-name="My Compose Project" template=compose
Expand Down
4 changes: 0 additions & 4 deletions Dangerfile
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,6 @@ end
# Show Danger test coverage report from Kover for templates
# Report coverage of modified files, warn if total project coverage is under 80%
# or if any modified file's coverage is under 95%
kover_file_template_xml = "template-xml/app/build/reports/kover/report.xml"
markdown "## Kover report for template-xml:"
shroud.reportKover "Template - XML Unit Tests", kover_file_template_xml, 80, 95, false

kover_file_template_compose = "template-compose/app/build/reports/kover/report.xml"
markdown "## Kover report for template-compose:"
shroud.reportKover "Template - Compose Unit Tests", kover_file_template_compose, 80, 95, false
Loading
Loading