Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release] 3.25.0 #550

Merged
merged 31 commits into from
Oct 31, 2023
Merged

[Release] 3.25.0 #550

merged 31 commits into from
Oct 31, 2023

Conversation

ryan-conway
Copy link
Collaborator

ryan-conway and others added 30 commits October 3, 2023 02:47
@ryan-conway @bot-nimble
[Chore] Bump version to 3.25.0
5eb9b25
@ryan-conway
Merge pull request #524 from nimblehq/chore/bump-version-to-3.25.0
8450038 
[Chore] Bump version to 3.25.0
@ryan-conway
[#502] Remove bump xml sample version from workflow
a7ab8fc
@ryan-conway
[#500] Remove unnecessary token from checkout action
0e49800
@ryan-conway
[#500] Update checkout action version and name for consistency
031ff62
@ryan-conway
[#521] Fix bump version workflow in .cicdtemplate
5cc995b
@ryan-conway
Merge pull request #532 from nimblehq/chore/500-the-checkout-step-in-…
cbfa993 
…bump_version-workflow-does-not-need-to-set-a-custom-token

[#500] The "Checkout" step in "bump_version" workflow does not need to set a custom token
@ryan-conway
Merge pull request #537 from nimblehq/bug/521-fix-the-bump_version-te…
bf97594 
…mplate-workflow-does-not-work

[#521] Fix: The bump_version template workflow does NOT work
@ryan-conway
Merge pull request #527 from nimblehq/chore/502-remove-bump-version-x…
1b3d92e 
…ml-step-from-bump-version-workflow

[#502] Remove Bump version XML step from Bump version workflow
@ryan-conway
[#538] Update all workflows to use Java 17
b17f703
@ryan-conway
[#538] Remove duplicate set up JDK steps
082ad3e
@ryan-conway
Merge pull request #540 from nimblehq/bug/538-fix-the-template-workfl…
eb30932 
…ows-fail-to-run-due-to-incorrect-java-version

[#538] Update all workflows to use Java 17
@thiennguyen0196
[#503] Deprecate xml templates
d50e45b
@thiennguyen0196
[#503] Update ci workflow
f4c1579
@thiennguyen0196
[#503] Update ci workflow
4b801c2
@thiennguyen0196
[#503] Update new project script prefix xml template name
f4b1cfd
@thiennguyen0196
[#503] Update readme
90ee187
@thiennguyen0196
[#503] Update danger template xml
538c71d
@thiennguyen0196
[#503] Update CI/CD workflow to remove xml template and rename rxjava…
f083e2d 
… template
@thiennguyen0196
[#503] Update script to remove generating xml project script
81f90a4
@thiennguyen0196
[#503] Update readme
8bd2c87
@thiennguyen0196
[#503] Make compose becomes default template
10e01c3
@thiennguyen0196
[#503] Update README
ed83e97
@ryan-conway
Merge pull request #519 from nimblehq/chore/503-deprecate-xml-template
ce05d6b 
[#503] Deprecate the XML template
@kaungkhantsoe
[#535] Update state flow to use asStateFlow
f78d181
@hoangnguyen92dn
[#543] Add default spacing dimensions
06dc8f5
@ryan-conway
Merge pull request #544 from nimblehq/feature/543-add-default-spacing…
590332a 
…-dimensions

[#543] Add default spacing definition in app dimensions
@kaungkhantsoe
[#535] Update state flow to use asStateFlow in base viewmodel classes
1d51e5d
@ryan-conway
Merge pull request #545 from nimblehq/feature/535-add-asstateflow-to-…
b90cbe3 
…viewmodel

[#535] Add asStateFlow to the StateFlow variables in ViewModel class
@kaungkhantsoe
[#462] Add concurrency for cicd
f2123c6
@ryan-conway
Merge pull request #546 from nimblehq/feature/462-add-support-for-con…
7a75d19 
…currency-cicd

[#462] Update GitHub workflows to use concurrency
@ryan-conway ryan-conway added this to the 3.25.0 milestone Oct 31, 2023
@ryan-conway ryan-conway self-assigned this Oct 31, 2023
@ryan-conway ryan-conway temporarily deployed to template-compose October 31, 2023 03:06 — with GitHub Actions Inactive
@github-actions
Copy link

13 Warnings
⚠️ Uh oh! ApiServiceProvider.kt is under 95% coverage!
⚠️ Uh oh! BaseSharedPreferences.kt is under 95% coverage!
⚠️ Uh oh! BaseViewModel.kt is under 95% coverage!
⚠️ Uh oh! ConverterFactoryProvider.kt is under 95% coverage!
⚠️ Uh oh! DispatchersProviderImpl.kt is under 95% coverage!
⚠️ Uh oh! EncryptedSharedPreferences.kt is under 95% coverage!
⚠️ Uh oh! ErrorMapping.kt is under 95% coverage!
⚠️ Uh oh! HomeScreen.kt is under 95% coverage!
⚠️ Uh oh! ResponseMapping.kt is under 95% coverage!
⚠️ Uh oh! RetrofitProvider.kt is under 95% coverage!
⚠️ Uh oh! SharedPreferencesExt.kt is under 95% coverage!
⚠️ Uh oh! UiModel.kt is under 95% coverage!
⚠️ Uh oh! Your project is under 80% coverage!

Kover report for template-compose:

🧛 Template - Compose Unit Tests Code Coverage: 63.04%

Coverage of Modified Files:

File Coverage
ApiServiceProvider.kt 0.00%
AppDimensions.kt 100.00%
AppPreferencesRepositoryImpl.kt 100.00%
BaseSharedPreferences.kt 0.00%
BaseViewModel.kt 73.91%
ConverterFactoryProvider.kt 0.00%
DispatchersProviderImpl.kt 0.00%
EncryptedSharedPreferences.kt 0.00%
Error.kt 100.00%
ErrorMapping.kt 68.75%
ErrorResponse.kt 100.00%
Exceptions.kt 100.00%
HomeScreen.kt 63.66%
HomeViewModel.kt 100.00%
MainActivity.kt 100.00%
MainApplication.kt 100.00%
Model.kt 100.00%
MoshiBuilderProvider.kt 100.00%
RepositoryImpl.kt 100.00%
Response.kt 100.00%
ResponseMapping.kt 90.85%
RetrofitProvider.kt 0.00%
SharedPreferencesExt.kt 0.00%
UiModel.kt 84.21%
UseCase.kt 100.00%

Modified Files Not Found In Coverage Report:

.gitignore
.gitignore
.gitignore
.gitignore
.gitignore
.gitignore
.gitignore
.gitignore
.gitignore
.gitignore
.gitignore
.gitignore
.gitignore
.gitignore
.gitignore
.gitignore
Alias.kt
AndroidManifest.xml
AndroidManifest.xml
AndroidManifest.xml
AndroidManifest.xml
AndroidManifest.xml
AndroidManifest.xml
AndroidManifest.xml
AndroidManifest.xml
AndroidManifest.xml
AndroidManifest.xml
ApiConst.kt
ApiEndpointUrl.kt
ApiEndpointUrlImpl.kt
ApiEndpointUrlImpl.kt
ApiRepository.kt
ApiRepositoryTest.kt
ApiService.kt
ApiService.kt
ApiService.kt
ApiServiceTest.kt
AppError.kt
AppFlowTest.kt
AppModule.kt
AppModule.kt
AppModule.kt
AppPreferencesRepository.kt
AppPreferencesRepository.kt
AppPreferencesRepositoryImplTest.kt
AppPreferencesRepositoryImplTest.kt
AppRequestInterceptor.kt
AppWebChromeClient.kt
Appfile
BaseActivity.kt
BaseActivity.kt
BaseActivity.kt
BaseFragment.kt
BaseFragment.kt
BaseFragment.kt
BaseFragmentCallbacks.kt
BaseFragmentCallbacks.kt
BaseFragmentCallbacks.kt
BaseFragmentTest.kt
BaseFragmentTest.kt
BaseFragmentTest.kt
BaseNavigator.kt
BaseNavigator.kt
BaseNavigator.kt
BaseUseCase.kt
ClientId.kt
ClientIdImpl.kt
ClientIdImpl.kt
ClientSecret.kt
ClientSecretImpl.kt
ClientSecretImpl.kt
CompletableUseCase.kt
Configurations.kt
Configurations.kt
Configurations.kt
Const.kt
Dangerfile
Data.kt
DataAdapter.kt
DataError.kt
DispatchersProvider.kt
DispatchersProvider.kt
EmptyHiltActivity.kt
EmptyHiltActivity.kt
EmptyHiltActivity.kt
ExampleApiRequest.kt
ExampleApiResponse.kt
Fastfile
FileExt.kt
FileExt.kt
FileExt.kt
FlowableNeverErrorTransformer.kt
FlowableUseCase.kt
FragmentComponentsModule.kt
Gemfile
Gemfile.lock
GetExampleDataUseCase.kt
GetExampleDataUseCaseTest.kt
GetModelsUseCase.kt
GetModelsUseCaseTest.kt
GlideModule.kt
Home.kt
HomeFragment.kt
HomeFragment.kt
HomeFragment.kt
HomeFragmentTest.kt
HomeFragmentTest.kt
HomeFragmentTest.kt
HomeViewModelTest.kt
ImageTransformation.kt
ImageViewExtension.kt
IsFirstTimeLaunchPreferencesUseCase.kt
IsFirstTimeLaunchPreferencesUseCaseTest.kt
Item.kt
ItemClickable.kt
ItemListAdapter.kt
KeywordExtension.kt
KeywordExtensionKtTest.kt
MainActivityModule.kt
MainActivityModule.kt
MainNavigator.kt
MainNavigator.kt
MainNavigator.kt
MainNavigatorTest.kt
MainViewModel.kt
MainViewModel.kt
MainViewModel.kt
MockUtil.kt
MockUtil.kt
MockUtil.kt
MoshiModule.kt
MoshiModule.kt
MoshiModule.kt
NavArgsExt.kt
NavArgsExt.kt
NavArgsExt.kt
NavArgsExt.kt
NavigationError.kt
NavigationEvent.kt
NavigationEvent.kt
NavigationEvent.kt
NavigationException.kt
NavigationException.kt
NavigatorModule.kt
NavigatorModule.kt
NormalSharedPreferences.kt
ObservableExt.kt
OkHttpClientModule.kt
OkHttpClientModule.kt
OkHttpClientModule.kt
Optional.kt
Pluginfile
PreferencesModule.kt
PreferencesModule.kt
README.md
README.md
README.md
README.md
README.md
Repository.kt
Repository.kt
RepositoryModule.kt
RepositoryModule.kt
RepositoryModule.kt
RepositoryTest.kt
RepositoryTest.kt
ResponseMappingTest.kt
ResponseMappingTest.kt
ResponseMappingTest.kt
RetrofitModule.kt
RetrofitModule.kt
RetrofitModule.kt
RxJavaExtension.kt
RxJavaTemplateApplication.kt
RxViewExt.kt
SchedulerProvider.kt
Second.kt
SecondBundle.kt
SecondFragment.kt
SecondFragment.kt
SecondFragmentTest.kt
SecondFragmentTest.kt
SecondFragmentUnitTest.kt
SecondViewModel.kt
SecondViewModel.kt
SecondViewModelTest.kt
Secrets.kt
SharePreferencesExt.kt
SingleUseCase.kt
StorageModule.kt
StorageModule.kt
StorageModule.kt
SupportEdge2EdgeHelper.kt
TakeWhenTransformer.kt
TestApiRepositoryImpl.kt
TestModules.kt
TestModules.kt
TestModules.kt
TestRepositoryModule.kt
TestRunner.kt
TestUtil.kt
Toaster.kt
Toaster.kt
Toaster.kt
Transformers.kt
TypeAlias.kt
TypeAlias.kt
UpdateFirstTimeLaunchPreferencesUseCase.kt
UpdateFirstTimeLaunchPreferencesUseCaseTest.kt
UseCaseTest.kt
ValidateError.kt
Versions.kt
Versions.kt
Versions.kt
Versions.kt
ViewModelExt.kt
ViewModelExt.kt
ViewModelExt.kt
ViewModelExt.kt
ViewModelExt.kt
ViewModelExt.kt
ViewModelFactory.kt
WebView.kt
WebViewBundle.kt
WebViewExt.kt
WebViewFragment.kt
WebViewFragmentTest.kt
WebViewViewModel.kt
WebViewViewModelTest.kt
activity_main.xml
activity_main.xml
activity_main.xml
build.gradle.kts
build.gradle.kts
build.gradle.kts
build.gradle.kts
build.gradle.kts
build.gradle.kts
build.gradle.kts
build.gradle.kts
build.gradle.kts
build.gradle.kts
build.gradle.kts
build.gradle.kts
build.gradle.kts
build.gradle.kts
build.gradle.kts
build.gradle.kts
build.rb
bump_version.yml
bump_version.yml
checkstyle-custom.xsl
checkstyle.xml
circularstd_bold.otf
circularstd_book.otf
codemagic.yaml
codequality.gradle.kts
colors.xml
colors.xml
colors.xml
colors.xml
colors.xml
colors_pallete.xml
config.rb
debug.keystore
debug.keystore
deploy_staging_and_production_to_firebase_app_distribution.yml
detekt-config.yml
detekt-config.yml
detekt-config.yml
dimens.xml
dimens.xml
dimens_text.xml
draft-new-release.yml
fragment_home.xml
fragment_home.xml
fragment_home.xml
fragment_second.xml
fragment_second.xml
fragment_webview.xml
gradle-wrapper.jar
gradle-wrapper.jar
gradle-wrapper.jar
gradle-wrapper.properties
gradle-wrapper.properties
gradle-wrapper.properties
gradle.properties
gradle.properties
gradle.properties
gradlew
gradlew
gradlew
gradlew.bat
gradlew.bat
gradlew.bat
ic_launcher.png
ic_launcher.png
ic_launcher.png
ic_launcher.png
ic_launcher.png
ic_launcher.png
ic_launcher.png
ic_launcher.png
ic_launcher.png
ic_launcher.png
ic_launcher.png
ic_launcher.png
ic_launcher.png
ic_launcher.png
ic_launcher.png
ic_launcher.xml
ic_launcher.xml
ic_launcher.xml
ic_launcher_background.xml
ic_launcher_background.xml
ic_launcher_background.xml
ic_launcher_foreground.xml
ic_launcher_foreground.xml
ic_launcher_foreground.xml
ic_launcher_round.png
ic_launcher_round.png
ic_launcher_round.png
ic_launcher_round.png
ic_launcher_round.png
ic_launcher_round.png
ic_launcher_round.png
ic_launcher_round.png
ic_launcher_round.png
ic_launcher_round.png
ic_launcher_round.png
ic_launcher_round.png
ic_launcher_round.png
ic_launcher_round.png
ic_launcher_round.png
ic_launcher_round.xml
ic_launcher_round.xml
ic_launcher_round.xml
item_data.xml
item_home_list.xml
jacoco.gradle.kts
nav_graph_main.xml
nav_graph_main.xml
nav_graph_main.xml
network_security_config.xml
network_security_config.xml
network_security_config.xml
network_security_config.xml
network_security_config.xml
network_security_config.xml
new_project.kts
org.mockito.plugins.MockMaker
proguard-rules.pro
proguard-rules.pro
proguard-rules.pro
proguard-rules.pro
proguard-rules.pro
proguard-rules.pro
proguard-rules.pro
publish_docs_to_wiki.yml
review_pull_request.yml
review_pull_request.yml
robolectric.properties
robolectric.properties
robolectric.properties
run_detekt_and_unit_tests.yml
run_detekt_and_unit_tests.yml
settings.gradle.kts
settings.gradle.kts
settings.gradle.kts
signing.properties
signing.properties
signing.properties
strings.xml
strings.xml
strings.xml
strings.xml
strings.xml
strings.xml
strings.xml
strings_tokens_and_keys.xml
styles.xml
styles.xml
styles.xml
verify_newproject_script.yml
version.properties
view_loading.xml
widget_styles.xml

Codebase cunningly covered by count Shroud 🧛

Generated by 🚫 Danger

@ryan-conway ryan-conway marked this pull request as ready for review October 31, 2023 03:13
@ryan-conway ryan-conway merged commit 1958f2a into main Oct 31, 2023
4 checks passed
@ryan-conway ryan-conway deleted the release/3.25.0 branch October 31, 2023 08:31
This was referenced Nov 23, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaungkhantsoe kaungkhantsoe kaungkhantsoe approved these changes

@luongvo luongvo luongvo approved these changes

@chornerman chornerman chornerman approved these changes

@AVI5HEK AVI5HEK Awaiting requested review from AVI5HEK AVI5HEK is a code owner

@doannimble doannimble Awaiting requested review from doannimble

@hoangnguyen92dn hoangnguyen92dn Awaiting requested review from hoangnguyen92dn hoangnguyen92dn is a code owner

@lydiasama lydiasama Awaiting requested review from lydiasama

@manh-t manh-t Awaiting requested review from manh-t manh-t is a code owner

@minhnimble minhnimble Awaiting requested review from minhnimble minhnimble is a code owner

@sleepylee sleepylee Awaiting requested review from sleepylee sleepylee is a code owner

@thiennguyen0196 thiennguyen0196 Awaiting requested review from thiennguyen0196

@toby-thanathip toby-thanathip Awaiting requested review from toby-thanathip toby-thanathip is a code owner

@Wadeewee Wadeewee Awaiting requested review from Wadeewee

Assignees

@ryan-conway ryan-conway

Labels
type : release
Projects
None yet
Milestone
3.25.0
Development

Successfully merging this pull request may close these issues.
6 participants
@ryan-conway @chornerman @luongvo @kaungkhantsoe @thiennguyen0196 @hoangnguyen92dn