Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#543] Add default spacing definition in app dimensions #544

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

hoangnguyen92dn
Copy link
Contributor

@hoangnguyen92dn hoangnguyen92dn commented Oct 19, 2023

#543

What happened 👀

We're adopting a new approach. The medium space is defined as 16.dp, with a spacing step of 4.dp. This simplifies both memorization and reference.

    val spacing2XSmall = 4.dp
    val spacingXSmall = 8.dp
    val spacingSmall = 12.dp
    val spacingMedium = 16.dp
    val spacingLarge = 20.dp
    val spacingXLarge = 24.dp
    val spacing2XLarge = 28.dp
    val spacing3XLarge = 32.dp

Insight 📝

  • Add default spacing definition in template-compose and sample-compose

Proof Of Work 📹

N/A

@github-actions
Copy link

github-actions bot commented Oct 19, 2023

2 Warnings
⚠️ Uh oh! HomeScreen.kt is under 95% coverage!
⚠️ Uh oh! Your project is under 80% coverage!

Kover report for template-compose:

🧛 Template - Compose Unit Tests Code Coverage: 63.04%

Coverage of Modified Files:

File Coverage
AppDimensions.kt 100.00%
HomeScreen.kt 63.66%

Modified Files Not Found In Coverage Report:

Item.kt

Codebase cunningly covered by count Shroud 🧛

Generated by 🚫 Danger

@kaungkhantsoe
Copy link
Contributor

Optional: @hoangnguyen92dn Can you amend the commit message to [#543] Add default spacing dimensions?

@hoangnguyen92dn hoangnguyen92dn force-pushed the feature/543-add-default-spacing-dimensions branch from b9eaea0 to 06dc8f5 Compare October 19, 2023 10:34
@hoangnguyen92dn hoangnguyen92dn temporarily deployed to template-compose October 19, 2023 10:34 — with GitHub Actions Inactive
@hoangnguyen92dn
Copy link
Contributor Author

@kaungkhantsoe Updated 🚀

@luongvo luongvo linked an issue Oct 20, 2023 that may be closed by this pull request
@ryan-conway ryan-conway merged commit 590332a into develop Oct 20, 2023
3 checks passed
@ryan-conway ryan-conway deleted the feature/543-add-default-spacing-dimensions branch October 20, 2023 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add default spacing definition in app dimensions
6 participants