Merge pull request #544 from nimblehq/feature/543-add-default-spacing…

…-dimensions [#543] Add default spacing definition in app dimensions
nimblehq · Oct 20, 2023 · 590332a · 590332a
2 parents ce05d6b + 06dc8f5
commit 590332a
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 5 deletions.
diff --git a/sample-compose/app/src/main/java/co/nimblehq/sample/compose/ui/screens/home/Item.kt b/sample-compose/app/src/main/java/co/nimblehq/sample/compose/ui/screens/home/Item.kt
@@ -33,13 +33,13 @@ fun Item(
         Row {
             Text(
                 modifier = Modifier
-                    .padding(dimensions.spacingNormal)
+                    .padding(dimensions.spacingMedium)
                     .weight(1f),
                 text = uiModel.id
             )
             Text(
                 modifier = Modifier
-                    .padding(dimensions.spacingNormal)
+                    .padding(dimensions.spacingMedium)
                     .weight(2f),
                 text = uiModel.username
             )

diff --git a/sample-compose/app/src/main/java/co/nimblehq/sample/compose/ui/theme/AppDimensions.kt b/sample-compose/app/src/main/java/co/nimblehq/sample/compose/ui/theme/AppDimensions.kt
@@ -5,7 +5,14 @@ import androidx.compose.ui.unit.dp
 
 class AppDimensions {
     // Custom dimensions here
-    val spacingNormal = 16.dp
+    val spacing2XSmall = 4.dp
+    val spacingXSmall = 8.dp
+    val spacingSmall = 12.dp
+    val spacingMedium = 16.dp
+    val spacingLarge = 20.dp
+    val spacingXLarge = 24.dp
+    val spacing2XLarge = 28.dp
+    val spacing3XLarge = 32.dp
 }
 
 internal val LocalAppDimensions = staticCompositionLocalOf { AppDimensions() }
diff --git a/...late-compose/app/src/main/java/co/nimblehq/template/compose/ui/screens/home/HomeScreen.kt b/...late-compose/app/src/main/java/co/nimblehq/template/compose/ui/screens/home/HomeScreen.kt
@@ -51,7 +51,7 @@ private fun HomeScreenContent(
             textAlign = TextAlign.Center,
             modifier = Modifier
                 .fillMaxWidth()
-                .padding(all = dimensions.spacingNormal)
+                .padding(all = dimensions.spacingMedium)
         )
     }
     Timber.d("Result : $uiModels")

diff --git a/template-compose/app/src/main/java/co/nimblehq/template/compose/ui/theme/AppDimensions.kt b/template-compose/app/src/main/java/co/nimblehq/template/compose/ui/theme/AppDimensions.kt
@@ -5,7 +5,14 @@ import androidx.compose.ui.unit.dp
 
 class AppDimensions {
     // Custom dimensions here
-    val spacingNormal = 16.dp
+    val spacing2XSmall = 4.dp
+    val spacingXSmall = 8.dp
+    val spacingSmall = 12.dp
+    val spacingMedium = 16.dp
+    val spacingLarge = 20.dp
+    val spacingXLarge = 24.dp
+    val spacing2XLarge = 28.dp
+    val spacing3XLarge = 32.dp
 }
 
 internal val LocalAppDimensions = staticCompositionLocalOf { AppDimensions() }