Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#538] Update all workflows to use Java 17 #540

Merged
merged 2 commits into from
Oct 11, 2023
Merged

[#538] Update all workflows to use Java 17 #540

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b17f703
[#538] Update all workflows to use Java 17
ryan-conway Oct 9, 2023
082ad3e
[#538] Remove duplicate set up JDK steps
ryan-conway Oct 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...template/.github/workflows/deploy_staging_and_production_to_firebase_app_distribution.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,11 @@ jobs:
runs-on: ubuntu-latest
timeout-minutes: 30
steps:
- name: Set up JDK 11
- name: Set up JDK 17
uses: actions/setup-java@v3
with:
distribution: 'temurin'
java-version: '11'
java-version: '17'

- name: Set up timezone
uses: zcong1993/setup-timezone@master
Expand Down
4 changes: 2 additions & 2 deletions .cicdtemplate/.github/workflows/review_pull_request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,11 @@ jobs:
runs-on: ubuntu-latest
timeout-minutes: 30
steps:
- name: Set up JDK 11
- name: Set up JDK 17
uses: actions/setup-java@v3
with:
distribution: 'temurin'
java-version: '11'
java-version: '17'

- name: Checkout source code
uses: actions/checkout@v4
Expand Down
4 changes: 2 additions & 2 deletions .cicdtemplate/.github/workflows/run_detekt_and_unit_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,11 @@ jobs:
runs-on: ubuntu-latest
timeout-minutes: 30
steps:
- name: Set up JDK 11
- name: Set up JDK 17
uses: actions/setup-java@v3
with:
distribution: 'temurin'
java-version: '11'
java-version: '17'

- name: Set up timezone
uses: zcong1993/setup-timezone@master
Expand Down
10 changes: 2 additions & 8 deletions .github/workflows/review_pull_request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,11 @@ jobs:
timeout-minutes: 30
environment: template-compose
steps:
- name: Set up JDK 11
- name: Set up JDK 17
ryan-conway marked this conversation as resolved.
Show resolved Hide resolved
uses: actions/setup-java@v3
with:
distribution: 'temurin'
java-version: '11'
java-version: '17'

- name: Checkout source code
uses: actions/checkout@v4
Expand Down Expand Up @@ -47,12 +47,6 @@ jobs:

# template-compose

- name: Set up JDK 17
uses: actions/setup-java@v3
with:
distribution: 'temurin'
java-version: '17'

- name: Run Detekt on template-compose
working-directory: ./template-compose
run: ./gradlew detekt
Expand Down
6 changes: 0 additions & 6 deletions .github/workflows/run_detekt_and_unit_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,12 +52,6 @@ jobs:

# template-xml

- name: Set up JDK 11
uses: actions/setup-java@v3
with:
distribution: 'temurin'
java-version: '11'

- name: Run Detekt on template-xml
working-directory: ./template-xml
run: ./gradlew detekt
Expand Down
10 changes: 2 additions & 8 deletions .github/workflows/verify_newproject_script.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,11 @@ jobs:
runs-on: ubuntu-latest
timeout-minutes: 30
steps:
- name: Set up JDK 11
- name: Set up JDK 17
ryan-conway marked this conversation as resolved.
Show resolved Hide resolved
uses: actions/setup-java@v3
with:
distribution: 'temurin'
java-version: '11'
java-version: '17'

- name: Checkout source code
uses: actions/checkout@v4
Expand Down Expand Up @@ -44,12 +44,6 @@ jobs:
working-directory: scripts
run: kscript new_project.kts package-name=co.myxmlproject.example app-name="My XML Project" template=xml

- name: Set up JDK 17
uses: actions/setup-java@v3
with:
distribution: 'temurin'
java-version: '17'

- name: Verify generating new project from template-compose
working-directory: scripts
run: kscript new_project.kts package-name=co.mycomposeproject.example app-name="My Compose Project" template=compose
Expand Down
Loading