Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#538] Update all workflows to use Java 17 #540

Conversation

ryan-conway
Copy link
Collaborator

closes #538

What happened 👀

  • Updated all workflows to use Java 17 instead of Java 11

Insight 📝

N/A

Proof Of Work 📹

Generated project PR

image

@ryan-conway ryan-conway self-assigned this Oct 9, 2023
@ryan-conway ryan-conway temporarily deployed to template-compose October 9, 2023 10:10 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Oct 9, 2023

1 Warning
⚠️ Uh oh! Your project is under 80% coverage!

Kover report for template-xml:

🧛 Template - XML Unit Tests Code Coverage: 34.25%

Coverage of Modified Files:

File Coverage

Modified Files Not Found In Coverage Report:

deploy_staging_and_production_to_firebase_app_distribution.yml
review_pull_request.yml
review_pull_request.yml
run_detekt_and_unit_tests.yml
run_detekt_and_unit_tests.yml
verify_newproject_script.yml

Codebase cunningly covered by count Shroud 🧛

Kover report for template-compose:

🧛 Template - Compose Unit Tests Code Coverage: 62.05%

Coverage of Modified Files:

File Coverage

Modified Files Not Found In Coverage Report:

deploy_staging_and_production_to_firebase_app_distribution.yml
review_pull_request.yml
review_pull_request.yml
run_detekt_and_unit_tests.yml
run_detekt_and_unit_tests.yml
verify_newproject_script.yml

Codebase cunningly covered by count Shroud 🧛

Generated by 🚫 Danger

Copy link
Member

@luongvo luongvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess @thiennguyen0196 needs to remove this one from his PR

image

.github/workflows/review_pull_request.yml Show resolved Hide resolved
@ryan-conway ryan-conway temporarily deployed to template-compose October 11, 2023 03:42 — with GitHub Actions Inactive
@ryan-conway ryan-conway requested a review from luongvo October 11, 2023 03:58
@ryan-conway ryan-conway merged commit eb30932 into develop Oct 11, 2023
3 checks passed
@ryan-conway ryan-conway deleted the bug/538-fix-the-template-workflows-fail-to-run-due-to-incorrect-java-version branch October 11, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix: The template workflows fail to run due to incorrect Java version
4 participants