Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move modules config import #3301

Merged
merged 4 commits into from
Nov 28, 2024
Merged

Move modules config import #3301

merged 4 commits into from
Nov 28, 2024
+6 −5

Conversation

LouisLeNezet
Copy link

@LouisLeNezet LouisLeNezet commented Nov 28, 2024 •
edited
Loading

Fix #3300
This is a small fix to the order of modules config import.
This allow to have modules configuration in test profiles not overwritten by those made in modules.config.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@LouisLeNezet LouisLeNezet linked an issue Nov 28, 2024 that may be closed by this pull request
Include config modules.config in the wrong place ? #3300
Closed
@LouisLeNezet LouisLeNezet added bug Something isn't working template nf-core pipeline/component template labels Nov 28, 2024
@LouisLeNezet LouisLeNezet mentioned this pull request Nov 28, 2024
Merged
11 tasks
@codecov Codecov
Copy link

codecov bot commented Nov 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.88%. Comparing base (7284262) to head (aacc24d).
Report is 5 commits behind head on dev.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mirpedrol
mirpedrol approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please remember to update the CHANGELOG.md before merging 🙂

@LouisLeNezet LouisLeNezet merged commit 1dd8ea0 into nf-core:dev Nov 28, 2024
88 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirpedrol mirpedrol mirpedrol approved these changes

Assignees
No one assigned
Labels
bug Something isn't working template nf-core pipeline/component template
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Include config modules.config in the wrong place ?
2 participants
@LouisLeNezet @mirpedrol