Fix bug with creating .nf-core.yml file when it can't be found #2562
+4
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug (#2237) that occurs if you run
nf-core modules install
in a directory which does not yet have a.nf-core.yml
file. The user is promoted if they want to create the file, but then it walks up the tree searching for an.nf-core.yml
file and ends up at the root of the filesystem where it tries to create the file (/.nf-core.yml
) and fails:The fixed algorithm works in this case, and is also optimized to do fewer file existence checks (the current algorithm calls
get_first_available_path
twice for each directory which is not necessary).PR checklist
CHANGELOG.md
is updateddocs
is updated