Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify module template version string #2557

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Simplify module template version string #2557

merged 1 commit into from
Dec 6, 2023

Conversation

mahesh-panchal
Copy link
Member

Shortens the module template version string to remove the unnecessary echo and use a shorter sed manipulation.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@maxulysse
Copy link
Member

@mirpedrol anything we need to check with linting?

mirpedrol
mirpedrol approved these changes Dec 6, 2023
View reviewed changes
Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't lint the specific versions command so it looks good :)

Some tests are failing due to some tests we are running with the self-hosted runners, I would say you can ignore the in this case and merge 👍

@mahesh-panchal mahesh-panchal merged commit 59d50b9 into nf-core:dev Dec 6, 2023
18 of 19 checks passed
@mahesh-panchal mahesh-panchal deleted the remove_echo_from_version_string branch December 6, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirpedrol mirpedrol mirpedrol approved these changes

@maxulysse maxulysse maxulysse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mahesh-panchal @maxulysse @mirpedrol