Skip to content

Commit

Permalink
Changelog.
Browse files Browse the repository at this point in the history
  • Loading branch information
MatthiasZepper committed Nov 26, 2024
1 parent 43e5600 commit 2eca65c
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
### Download

- First steps towards fixing [#3179](https://github.com/nf-core/tools/issues/3179): Modify `prioritize_direct_download()` to retain Seqera Singularity https:// Container URIs and hardcode Seqera Containers into `gather_registries()` ([#3244](https://github.com/nf-core/tools/pull/3244)).
- Further steps towards fixing [#3179](https://github.com/nf-core/tools/issues/3179): Enable limited support for `oras://` container paths (_only absolute URIs, no flexible registries like with Docker_) and prevent unnecessary image downloads for Seqera Container modules with `reconcile_seqera_container_uris()` ([#3293](https://github.com/nf-core/tools/pull/3293)).

### Linting

Expand Down
6 changes: 3 additions & 3 deletions tests/pipelines/test_download.py
Original file line number Diff line number Diff line change
Expand Up @@ -435,7 +435,7 @@ def test_singularity_pull_image_singularity_installed(self, tmp_dir, mock_rich_p
with pytest.raises(ContainerError.NoSingularityContainerError):
download_obj.singularity_pull_image(
"oras://ghcr.io/matthiaszepper/umi-transfer:dev",
f"{tmp_dir}/umi-transfer-oras.sif",
f"{tmp_dir}/umi-transfer-oras_impostor.sif",
None,
"docker.io",
mock_rich_progress,
Expand All @@ -445,7 +445,7 @@ def test_singularity_pull_image_singularity_installed(self, tmp_dir, mock_rich_p
with pytest.raises(ContainerError.RegistryNotFoundError):
download_obj.singularity_pull_image(
"hello-world",
f"{tmp_dir}/hello-world_new.sif",
f"{tmp_dir}/break_the_registry_test.sif",
None,
"register-this-domain-to-break-the-test.io",
mock_rich_progress,
Expand Down Expand Up @@ -481,7 +481,7 @@ def test_singularity_pull_image_singularity_installed(self, tmp_dir, mock_rich_p
with pytest.raises(ContainerError.InvalidTagError):
download_obj.singularity_pull_image(
"ewels/multiqc:go-rewrite",
f"{tmp_dir}/umi-transfer.sif",
f"{tmp_dir}/multiqc-go.sif",
None,
"ghcr.io",
mock_rich_progress,
Expand Down

0 comments on commit 2eca65c

Please sign in to comment.