Bump Nextflow Versions #7019
Merged
Bump Nextflow Versions #7019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxulysse
approved these changes
Nov 19, 2024
| @@ -33,7 +35,7 @@ runs: | |||
| - name: Install nf-test | |||
| uses: nf-core/setup-nf-test@v1 | |||
| with: | |||
| version: "0.9.2" | |||
| version: "${{ env.NFTEST_VERSION }}" | |||
There was a problem hiding this comment.
Don't we use NFT_VERSION in other actions?
There was a problem hiding this comment.
Yeah that's what the renovate regex had by default. We could probably get away with VER
There was a problem hiding this comment.
I'd say we use *_VER because that's the default env name than NXF recognize, and we used NFT_VER to be coherent.
I'd rather NFT_VER, but I'm fine with whatever as long as use the same everywhere
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6664