Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'image/webp' mime type support #621

Closed
wants to merge 1 commit into from
Closed

Conversation

jficz
Copy link
Contributor

@jficz jficz commented Sep 30, 2020

Fixes #228

Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Support is only 80% though 🤔
https://caniuse.com/webp

But I guess this will make people upgrade. All latest supported browsers works with them. Including mobile devices 🤷

Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cptMikky Please add a working webp example on cypress though :)

@skjnldsv skjnldsv added 2. developing Work in progress enhancement New feature or request file support request Request support for a new mime type labels Oct 12, 2020
@aviallon
Copy link

aviallon commented Jan 18, 2021

Support is only 80% though thinking
https://caniuse.com/webp

It's 91.36% now, and growing. The camera app I use (OpenCamera) has an option to save pictures in webp, and this helped me reduce the file size of my pictures by 60%, which is non negligible.

Anything still holding back this pull request?

@skjnldsv
Copy link
Member

cc @rullzer

@skjnldsv
Copy link
Member

skjnldsv commented Jan 18, 2021

@cptMikky can you rebase? :)

@rullzer
Copy link
Member

rullzer commented Jan 20, 2021

SO what will happen if you open this on safari? (since safari has no webp support)
Will it do boom?

@skjnldsv
Copy link
Member

SO what will happen if you open this on safari? (since safari has no webp support)
Will it do boom?

Most likely display an "error loading xxx"

@rullzer
Copy link
Member

rullzer commented Jan 20, 2021

So ok I don't know enough about the viewer to be honest.
But will it use the preview endpoint by default or just try to display the file as is?

@jficz
Copy link
Contributor Author

jficz commented Jan 20, 2021

let me see what I can do

@jficz
Copy link
Contributor Author

jficz commented Jan 20, 2021

@skjnldsv rebased, added Cypress test (I have no idea how that thing works so I just copy-pasted what was already there and updated it for webp)

@jficz jficz requested a review from skjnldsv January 20, 2021 19:51
@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 21, 2021
@skjnldsv skjnldsv requested a review from rullzer January 21, 2021 11:12
@skjnldsv
Copy link
Member

For 22 we can get this in as we dropped IE! 🚀

@skjnldsv
Copy link
Member

Ah, this pr is not allowing me to rebase-push.
let me rebase on new pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request file support request Request support for a new mime type
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support webp format
4 participants