-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'image/webp' mime type support #621
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Support is only 80% though 🤔
https://caniuse.com/webp
But I guess this will make people upgrade. All latest supported browsers works with them. Including mobile devices 🤷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cptMikky Please add a working webp example on cypress though :)
It's 91.36% now, and growing. The camera app I use (OpenCamera) has an option to save pictures in webp, and this helped me reduce the file size of my pictures by 60%, which is non negligible. Anything still holding back this pull request? |
cc @rullzer |
@cptMikky can you rebase? :) |
SO what will happen if you open this on safari? (since safari has no webp support) |
Most likely display an "error loading xxx" |
So ok I don't know enough about the viewer to be honest. |
let me see what I can do |
Signed-off-by: Jakub Fiser <[email protected]>
@skjnldsv rebased, added Cypress test (I have no idea how that thing works so I just copy-pasted what was already there and updated it for |
For 22 we can get this in as we dropped IE! 🚀 |
Ah, this pr is not allowing me to rebase-push. |
Fixes #228