Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'image/webp' mime type support #855

Merged
merged 1 commit into from
Apr 12, 2021
Merged

Add 'image/webp' mime type support #855

merged 1 commit into from
Apr 12, 2021

Conversation

skjnldsv
Copy link
Member

Closes #621
Fixes #228

@skjnldsv skjnldsv added enhancement New feature or request 3. to review Waiting for reviews file support request Request support for a new mime type labels Apr 12, 2021
@skjnldsv skjnldsv added this to the Nextcloud 22 milestone Apr 12, 2021
@skjnldsv skjnldsv self-assigned this Apr 12, 2021
@skjnldsv skjnldsv requested review from szaimen and rullzer April 12, 2021 14:54
szaimen
szaimen approved these changes Apr 12, 2021
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test this but it looks good and is covered by a test that is passing hence approved 👍

@skjnldsv
Copy link
Member Author

image
Tests 👍

@skjnldsv skjnldsv merged commit 8c6de84 into master Apr 12, 2021
@skjnldsv skjnldsv deleted the add/image/webp branch April 12, 2021 15:19
@aviallon
Copy link

Wow, I was just going to check how was WebP support going... I am pleased to see that it is finally done!
Which release will have it available?

@szaimen
Copy link
Contributor

szaimen commented Apr 12, 2021

NC22 as you can see here:
image

@JanisPlayer JanisPlayer mentioned this pull request Sep 10, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szaimen szaimen szaimen approved these changes

@rullzer rullzer Awaiting requested review from rullzer

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews enhancement New feature or request file support request Request support for a new mime type
Projects
None yet
Milestone
Nextcloud 22
Development

Successfully merging this pull request may close these issues.

Support webp format
4 participants
@skjnldsv @aviallon @szaimen @beardhatcode