Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support webp format #228

Closed
Zibc opened this issue Jul 7, 2019 · 6 comments · Fixed by #855
Closed

Support webp format #228

Zibc opened this issue Jul 7, 2019 · 6 comments · Fixed by #855
Labels
3. to review Waiting for reviews file support request Request support for a new mime type good first issue Good for newcomers

Comments

@Zibc
Copy link

Zibc commented Jul 7, 2019

Hi there,

Is there any plan to add support for webp format in a near future ?

I already tried adding the mimetype as suggest in PR nextcloud/gallery#527, but it does not seem to have any effect (at least on NC 15)
@skjnldsv skjnldsv transferred this issue from nextcloud/gallery Sep 3, 2019
@skjnldsv
Copy link
Member

skjnldsv commented Sep 3, 2019

Moving to viewer!
Once nextcloud/gallery#540 is merged, we should have this unified

@skjnldsv skjnldsv added 1. to develop Accepted and waiting to be taken care of file support request Request support for a new mime type good first issue Good for newcomers labels Sep 3, 2019
@XeonG
Copy link

XeonG commented Aug 25, 2020

Can this be added please

@skjnldsv
Copy link
Member

@XeonG please provide a pull request :)

viewer/src/models/images.js

Line 34 in ae3e59a

'image/svg+xml',

@szaimen
Copy link
Contributor

szaimen commented Aug 25, 2020

I've looked for the mime-type:
image

@jficz jficz mentioned this issue Sep 30, 2020
Closed
@LiberteCzech

This comment has been minimized.

Sign in to view
@skjnldsv

This comment has been minimized.

Sign in to view
@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of labels Oct 12, 2020
@skjnldsv skjnldsv mentioned this issue Apr 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3. to review Waiting for reviews file support request Request support for a new mime type good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
5 participants
@XeonG @Zibc @LiberteCzech @skjnldsv @szaimen