feat: Move to vite for bundling #5367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusknorr
force-pushed
the
enh/vite
branch
6 times, most recently
from
3b4b9fe
to
93fc058
Compare
juliusknorr
force-pushed
the
enh/vite
branch
from
93fc058
to
24903e7
Compare
juliusknorr
force-pushed
the
enh/vite
branch
2 times, most recently
from
9081a0f
to
0ed9c1c
Compare
|
Build is also failing for me locally with
|
|
|
|
in public read only shares prosemirror.scss is not getting applied (did not look at editable shares yet) |
max-nextcloud
force-pushed
the
enh/vite
branch
4 times, most recently
from
44def8c
to
9da2f3f
Compare
Signed-off-by: Julius Härtl <[email protected]> Revert "fixup! fixup! fixup! feat: Move to vite for bundling" This reverts commit d3c2ac5.
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Max <[email protected]>
to fix node builds for now. Rollup is known to require quite a bit of memory when bundling with source maps enabled. https://rollupjs.org/troubleshooting/#error-javascript-heap-out-of-memory Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
took the `configFile: false` from nextcloud/forms. Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Looks like we were just being lucky and rules were in the right order before. With vite including the css in tags we cannot rely on this.--signoff Signed-off-by: Max <[email protected]>
Preview generation locks the file leading to occasional 423 responses on the delete request. Signed-off-by: Max <[email protected]>
max-nextcloud
approved these changes
May 17, 2024
|
@juliushaertl I cannot ask you for review because it's your PR. Would you take a look and merge if you think it's ready? |
juliusknorr
commented
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves js assets quite a lot, while more individual files are loaded the overall size by ~80%
Initial files app load
Before 17.43MB
After 3.94MB