Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Move to vite for bundling #5367

Merged
merged 10 commits into from
May 17, 2024
Merged

feat: Move to vite for bundling #5367

merged 10 commits into from
May 17, 2024

Commits on May 15, 2024

  1. feat: Move to vite for bundling 

    Signed-off-by: Julius Härtl <[email protected]>

Revert "fixup! fixup! fixup! feat: Move to vite for bundling"

This reverts commit d3c2ac5.
    @juliusknorr @max-nextcloud
    juliusknorr authored and max-nextcloud committed May 15, 2024
    Configuration menu
    Copy the full SHA
    e7450a0 View commit details
    Browse the repository at this point in the history

  2. chore: Add typescript support 

    Signed-off-by: Julius Härtl <[email protected]>
    @juliusknorr @max-nextcloud
    juliusknorr authored and max-nextcloud committed May 15, 2024
    Configuration menu
    Copy the full SHA
    f3adcff View commit details
    Browse the repository at this point in the history

  3. fix: test with ts 

    Signed-off-by: Julius Härtl <[email protected]>
    @juliusknorr @max-nextcloud
    juliusknorr authored and max-nextcloud committed May 15, 2024
    Configuration menu
    Copy the full SHA
    fc06a1d View commit details
    Browse the repository at this point in the history

  4. deps(cypress): drop browserify and webpack preprocessors 

    Signed-off-by: Max <[email protected]>
    @max-nextcloud
    max-nextcloud committed May 15, 2024
    Configuration menu
    Copy the full SHA
    f0b0461 View commit details
    Browse the repository at this point in the history

  5. fix(ci): NODE_OPTIONS: --max-old-space-size=4096 

    to fix node builds for now.

Rollup is known to require quite a bit of memory
when bundling with source maps enabled.
https://rollupjs.org/troubleshooting/#error-javascript-heap-out-of-memory

Signed-off-by: Max <[email protected]>
    @max-nextcloud
    max-nextcloud committed May 15, 2024
    Configuration menu
    Copy the full SHA
    b9ec061 View commit details
    Browse the repository at this point in the history

  6. fix(build): inline css in all relevant entry points 

    Signed-off-by: Max <[email protected]>
    @max-nextcloud
    max-nextcloud committed May 15, 2024
    Configuration menu
    Copy the full SHA
    9497b52 View commit details
    Browse the repository at this point in the history

  7. fix(cy): use cypress-vite to build cypress tests 

    took the `configFile: false` from nextcloud/forms.

Signed-off-by: Max <[email protected]>
    @max-nextcloud
    max-nextcloud committed May 15, 2024
    Configuration menu
    Copy the full SHA
    1227cda View commit details
    Browse the repository at this point in the history

  8. fix(cy): use node polyfills to provide path.basename 

    Signed-off-by: Max <[email protected]>
    @max-nextcloud
    max-nextcloud committed May 15, 2024
    Configuration menu
    Copy the full SHA
    145f5ac View commit details
    Browse the repository at this point in the history

  9. fix(css): make print rule more specific 

    Looks like we were just being lucky
and rules were in the right order before.

With vite including the css in tags we cannot rely on this.--signoff

Signed-off-by: Max <[email protected]>
    @max-nextcloud
    max-nextcloud committed May 15, 2024
    Configuration menu
    Copy the full SHA
    6261b84 View commit details
    Browse the repository at this point in the history

  10. fix(cy): delete after preview was loaded 

    Preview generation locks the file
leading to occasional 423 responses
on the delete request.

Signed-off-by: Max <[email protected]>
    @max-nextcloud
    max-nextcloud committed May 15, 2024
    Configuration menu
    Copy the full SHA
    8df979a View commit details
    Browse the repository at this point in the history