fix(outbox): catch failed SENT copy operation

[miaulalala]

Fixes #8435

Sending a mail could fail at any point in the send operation.

This PR aims to introduce clear status codes that allow for the send code to redo the operations that fail.

Everything except the actual IMAP send and copying the sent message to the SENT mailbox are idempotent.

[ChristophWurst]

Unassigning from the milestone because this is not a must have. We can merge at any time and backport.

[ChristophWurst]

Testing the case where CopySentMessageHandler fails: An exception occurred while executing a query: SQLSTATE[42S22]: Column not found: 1054 Unknown column 'raw' in 'field list' resulting in a HTTP500.

\OCP\AppFramework\Db\QBMapper::update is called with a LocalMessage

[ChristophWurst]

\OCA\Mail\Controller\OutboxController::send must not return a HTTP200 when the chain fails. Right now the outbox message disappears from the outbox until a page reload, then the message is back.

[miaulalala]

Testing the case where CopySentMessageHandler fails: An exception occurred while executing a query: SQLSTATE[42S22]: Column not found: 1054 Unknown column 'raw' in 'field list' resulting in a HTTP500.

\OCP\AppFramework\Db\QBMapper::update is called with a LocalMessage

Did you run the migration again? The "raw" field was introduced later.

[ChristophWurst]

Raw is a column for local messages, not messages

[ChristophWurst]

Successful case works ✔️
An error in \OCA\Mail\Send\CopySentMessageHandler::process shows an error toast in the front-end ✔️
After the error the message vanishes from the outbox. From a user perspective it's simply gone ❌

This is bad because the user will not find the message anywhere, making it look like it was never sent. Messages that failed to copy on IMAP but were sent should show in a transparent matter. As in, they stay in the outbox, visible, but read-only.

[ChristophWurst]

• BUG: Message that failed to copy to IMAP shows in inbox with no further information. The message is clickable, but clicking results in a silent error. Console:

• BUG: Send now does not work. I would expect to be able to manually retry/resume the sending process if it failed.

[ChristophWurst]

Failed messages appear in the outbox ✔️
Retried messages are processed by the worker job and finally disappear from the outbox ✔️

Frontend handling can be improved ^

[miaulalala]

Added a bit of shiny for the frontend

[ChristophWurst]

Clicking messages stuck in the outbox no longer causes an error ✔️

But the UX is strange. The message appears clickable but nothing happens on click. The cursor should be the default one, not pointer.

With the latest UI changes the ability to force resend/retry was lost. It's only possible to delete stuck outbox messages or wait for the cron job to retry/resend.

[miaulalala]

Clicking messages stuck in the outbox no longer causes an error ✔️

But the UX is strange. The message appears clickable but nothing happens on click. The cursor should be the default one, not pointer.

With the latest UI changes the ability to force resend/retry was lost. It's only possible to delete stuck outbox messages or wait for the cron job to retry/resend.

We can use an NcListItemIcon instead of the NcListItem that does the rendering for the pointer,. Since NcListItem it also does the rendering for the status message, it's kinda weird though.

There's no prop that I can see that will allow the pointer to be set for the NcListItem component. The styles don't really work well together for the NcListItem and NcListItemIcon (first one is NcListItemIcon, second and third are NcListItem):

I changed the actions button to include the "send" action again for messages not copied to the sent mailbox but labeled it 'Copy to "Sent" mailbox'

[miaulalala]

On further thinking I'd actually like to see the right panel being used. We could treat outbox messages like "Sent" messages and display them like a regular email, with an "Edit" button for anything that's not been sent yet. Would get rid of the awkward unused message content space and allow for a preview of any sent messages. cc @nimishavijay

For now, I'd leave the NcListItem even though it's a tiny bit awkward with the non- action on click unless a frontender wants to take a real shot at refactoring the whole thing to render better than my awkward try with the NcListItemIcon.

[ChristophWurst]

Then we leave the cursor pointer or use :v-deep to overwrite it

Once force send is back, conflicts are resolved and CI is green we can merge this

[miaulalala]

Then we leave the cursor pointer or use :v-deep to overwrite it

Once force send is back, conflicts are resolved and CI is green we can merge this

force send is a different PR, no?

[ChristophWurst]

With the latest UI changes the ability to force resend/retry was lost. It's only possible to delete stuck outbox messages or wait for the cron job to retry/resend.

This is what I mean by "force" resend. When storing on IMAP fails temporarily I want to be able to retry.

[ChristophWurst]

• Unhandled js errors when simulating the error case of Mail both "Sent" and stuck in Outbox #8435

[ChristophWurst]

When I retry and it still fails

[ChristophWurst]

Related tests fail

[ChristophWurst]

Tested & works

[miaulalala]

/backport to stable3.6