Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: honour MDN requests #9473

Merged
merged 1 commit into from
Jun 10, 2024
Merged

fix: honour MDN requests #9473

merged 1 commit into from
Jun 10, 2024

Conversation

miaulalala
Copy link
Contributor

Needs #9364

Fixes #9365

image

@miaulalala miaulalala added this to the v3.6.0 milestone Mar 19, 2024
@miaulalala miaulalala self-assigned this Mar 19, 2024
@ChristophWurst ChristophWurst removed this from the v3.6.0 milestone Mar 19, 2024
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good 👍

@miaulalala miaulalala force-pushed the fix/honour-mdn-requests branch 2 times, most recently from 9ebdc77 to 89e63f3 Compare May 6, 2024 16:38
@miaulalala miaulalala removed the blocked label May 6, 2024
@miaulalala miaulalala marked this pull request as draft May 7, 2024 11:10
@miaulalala miaulalala force-pushed the fix/honour-mdn-requests branch from 89e63f3 to bc77447 Compare June 7, 2024 09:20
@miaulalala miaulalala marked this pull request as ready for review June 7, 2024 09:23
@miaulalala
Copy link
Contributor Author

/backport to stable3.7

Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works (mostly).

Some feedback:

  1. Please adjust version in info.xml to trigger the migration.
  2. MDN state is lost when saving a draft, closing it and editing it again. EDIT: Can't be solved because this information is lost when going through IMAP.
  3. MDN state is also lost when canceling a message in the outbox.

Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works. I addressed my own feedback.

appinfo/info.xml Outdated Show resolved Hide resolved
Signed-off-by: Anna Larch <[email protected]>
@miaulalala miaulalala force-pushed the fix/honour-mdn-requests branch from a2bb967 to 752b012 Compare June 10, 2024 08:13
@miaulalala miaulalala merged commit bd207b1 into main Jun 10, 2024
34 of 35 checks passed
@miaulalala miaulalala deleted the fix/honour-mdn-requests branch June 10, 2024 08:21
@backportbot backportbot bot mentioned this pull request Jun 10, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MDN Requests are not honoured
3 participants