aio-interface: Improve psalm

[docjyJ]

Fix warnings generated by phpstorm

• Add psalm:strict until type and unused class warnings are fixed (a lot 277 other issues found.)
• https://psalm.dev/docs/running_psalm/configuration/
• 

[docjyJ]

Found 43 of 43 files that can be fixed in 6.985 seconds, 30.00 MB memory used
Please run `composer run cs:fix` to format your code
Error: Process completed with exit code 1.

Perfect, the workflow works, it fails successfully ^^'

PR ready

[szaimen]

Perfect, the workflow works, it fails successfully ^^'

I fear we cannot merge this with red ci. Can you run cs fix and commit the changes in a separate pr that builds on this branch?

Also the changes to psalm seem to be unrelated? Can you put this into a separate pr please?

[docjyJ]

I fear we cannot merge this with red ci. Can you run cs fix and commit the changes in a separate pr that builds on this branch?

I know...

Also the changes to psalm seem to be unrelated? Can you put this into a separate pr please?

I don't know, it is link with <!--TODO: errorLevel="1" see PR #5369-->.

[docjyJ]

ok psalm done

[docjyJ]

ok see #5370 for CS

[szaimen]

Seems like static analysis is failing now :/

Can we increase the error level in a follow-up?

[docjyJ]

------------------------------
284 errors found
------------------------------
Psalm can automatically fix 3 of these issues.
Run Psalm again with 
--alter --issues=UnusedVariable --dry-run
to see what it can fix.
------------------------------

In commit c20a8f8
I switched psalm to error level 1. The strict command is no longer useful, so I removed it.

The problem is that the workflow fails.

This is due to some problems in the code.

Ideally it would be good to switch to level 1. This avoids using variables of type mixed and unused variables. IDEs can be more efficient for autocompletion, and psalm can warn of type errors more easily.

[docjyJ]

Seems like static analysis is failing now :/

Can we increase the error level in a follow-up?

That's why I used a TODO comment and added the stric composer script.
The idea is to improve the code little by little and at some point definitely move to level 1.

[docjyJ]

Issue in code:

• MixedArgument
• MixedArrayAccess
• MixedArrayAssignment
• MixedArrayOffset
• MixedAssignment <- How to fix
• MixedInferredReturnType
• MixedMethodCall <- Why this is bad and How to fix
• MixedOperand <- Why this is bad
• MixedPropertyTypeCoercion
• MixedReturnStatement
• PossiblyNullOperand
• UnusedClosureParam
• UnusedVariable

Command used:

composer run psalm -- --monochrome --no-progress | grep ^ERROR | sed -e 's/^ERROR: //' | sort -u

[szaimen]

Seems like static analysis is failing now :/
Can we increase the error level in a follow-up?

That's why I used a TODO comment and added the stric composer script. The idea is to improve the code little by little and at some point definitely move to level 1.

Ah I see. Can we for now switch back to errorlevel2 and then in follow-ups resolve the issues?

[docjyJ]

I drop the commit

[docjyJ]

I don't know if you've seen it yet, but I've started working on stalwart integration. I'm trying to apply strict rules in static analysis.

https://github.com/docjyJ/stalwart-connector

(I recently got into rust and really enjoyed it. I'm a bit of a neat freak, but I think it's important to avoid errors. 😅)

[docjyJ]

Follow up #5368

[docjyJ]

I found that in psalm doc: https://psalm.dev/docs/manipulating_code/fixing/

[szaimen]

LGTM, thanks 😊

[szaimen]

I found that in psalm doc: https://psalm.dev/docs/manipulating_code/fixing/

This sounds cool as an additonal command maybe? :)

[szaimen]

I don't know if you've seen it yet, but I've started working on stalwart integration. I'm trying to apply strict rules in static analysis.

https://github.com/docjyJ/stalwart-connector

(I recently got into rust and really enjoyed it. I'm a bit of a neat freak, but I think it's important to avoid errors. 😅)

Also this looks very interesting! Cool that you started working on it 😊

[docjyJ]

I found that in psalm doc: https://psalm.dev/docs/manipulating_code/fixing/

This sounds cool as an additonal command maybe? :)

I think this should be added globally to the Nextcloud style rule to maintain consistency.

[docjyJ]

I don't know if you've seen it yet, but I've started working on stalwart integration. I'm trying to apply strict rules in static analysis.
https://github.com/docjyJ/stalwart-connector
(I recently got into rust and really enjoyed it. I'm a bit of a neat freak, but I think it's important to avoid errors. 😅)

Also this looks very interesting! Cool that you started working on it 😊

Thank you! If you have time, don't hesitate to give feedback.

[szaimen]

This is now released with v9.7.0 Beta. Testing and feedback is welcome! See https://github.com/nextcloud/all-in-one#how-to-switch-the-channel