Clean code, resolve psalm type error #5308
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @docjyJ, this is a very nice idea! Thanks for starting to work on this. I think for reviews it would be best if you could create separate PRs, one for each file if possible or at least grouped in some other way. Thanks a lot! :) |
docjyJ
force-pushed
the
enh/noid/optimize-psalm
branch
from
12b9317 to
5187ea6
Compare
|
Ok, so you can review this PR |
szaimen
added
3. to review
22 tasks
Signed-off-by: Jean-Yves <[email protected]>
Signed-off-by: Jean-Yves <[email protected]>
Signed-off-by: Jean-Yves <[email protected]>
Signed-off-by: Jean-Yves <[email protected]>
Signed-off-by: Jean-Yves <[email protected]>
Signed-off-by: Jean-Yves <[email protected]>
docjyJ
force-pushed
the
enh/noid/optimize-psalm
branch
from
1e4f32f to
25e2dd8
Compare
8 tasks
|
See #5369 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey
When you are running
composer run psalm -- --show-info=truePsalm report a lot of type error.The goal of this PR is to fix these errors through type checking.
It is always more pleasant to develop without waring everywhere.
What do you think? I find it quite relaxing to clean up code. If you think it's a good idea, I can take care of that task.