-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move opentelemetry redis example to examples repository #17555
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -45,16 +45,16 @@ Refer to our | |
[documentation and examples](/docs/more-integrations/open-source-telemetry-integrations/opentelemetry/get-started/opentelemetry-set-up-your-app) | ||
for monitoring service entities using OpenTelemetry. | ||
|
||
#### Required attributes | ||
#### Required attributes [#service-required-attributes] | ||
|
||
* [`service.name`](https://opentelemetry.io/docs/specs/semconv/attributes-registry/service): The service name you see in the UI comes from this value. | ||
|
||
#### Recommended attributes [#recommended-attributes] | ||
#### Recommended attributes [#service-recommended-attributes] | ||
|
||
* [`service.instance.id`](https://opentelemetry.io/docs/specs/semconv/attributes-registry/service): Enables faceting between multiple instances of the same service. | ||
* [`telemetry.sdk.language`](https://opentelemetry.io/docs/specs/semconv/attributes-registry/telemetry): When present, this value drives the display of any runtime-specific UI, such as the JVM runtime page for Java applications. | ||
|
||
#### Entity tags [#entity-tags] | ||
#### Entity tags [#service-entity-tags] | ||
|
||
* [`service.namespace`](https://opentelemetry.io/docs/specs/semconv/attributes-registry/service) | ||
* [`telemetry.sdk.language`](https://opentelemetry.io/docs/specs/semconv/attributes-registry/telemetry) (added as language tag) | ||
|
@@ -68,16 +68,14 @@ for monitoring service entities using OpenTelemetry. | |
A host entity is synthesized by adhering to the OpenTelemetry resource semantic | ||
conventions describing a [host](https://opentelemetry.io/docs/specs/semconv/resource/host). | ||
|
||
Refer to our | ||
[documentation](/docs/more-integrations/open-source-telemetry-integrations/opentelemetry/collector/opentelemetry-collector-infra-hosts) | ||
for monitoring host entities using the host metrics receiver for the OpenTelemetry collector. | ||
Refer to the host monitoring example in [collector for infrastructure monitoring](/docs/more-integrations/open-source-telemetry-integrations/opentelemetry/get-started/collector-infra-monitoring/opentelemetry-collector-infra-intro/) for more details. | ||
|
||
#### Required attributes [#required-attributes] | ||
#### Required attributes [#host-required-attributes] | ||
|
||
* [`host.name`](https://opentelemetry.io/docs/specs/semconv/attributes-registry/host): The host name you see in the UI comes from this value. | ||
* [`host.id`](https://opentelemetry.io/docs/specs/semconv/attributes-registry/host) | ||
|
||
#### Entity tags [#entity-tags] | ||
#### Entity tags [#host-entity-tags] | ||
|
||
* [`cloud.provider`](https://opentelemetry.io/docs/specs/semconv/attributes-registry/cloud) | ||
* [`cloud.account.id`](https://opentelemetry.io/docs/specs/semconv/attributes-registry/cloud) | ||
|
@@ -92,6 +90,29 @@ for monitoring host entities using the host metrics receiver for the OpenTelemet | |
* [`host.image.id`](https://opentelemetry.io/docs/specs/semconv/attributes-registry/host) | ||
* [`host.image.version`](https://opentelemetry.io/docs/specs/semconv/attributes-registry/host) | ||
|
||
### Redis instances [#redis] | ||
|
||
A redis instance is synthesized using data emitted from the collector [redis receiver](https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/receiver/redisreceiver). Unfortunately, there are currently no semantic conventions for redis instances, or identifying attributes in the metrics the redis receiver emits. Therefore, users are required to manually include the attributes described below. | ||
|
||
Refer to the redis example in [collector for infrastructure monitoring](/docs/more-integrations/open-source-telemetry-integrations/opentelemetry/get-started/collector-infra-monitoring/opentelemetry-collector-infra-intro/) for more details. | ||
|
||
#### Required attributes [#redis-required-attributes] | ||
|
||
* [`server.address`](https://opentelemetry.io/docs/specs/semconv/attributes-registry/server/): The redis instance name you see in the UI comes from this value. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. See entity definition for reference: https://github.com/newrelic/entity-definitions/blame/c13e7a5d7150556c3980a64cd44047f70f3bdca0/entity-types/infra-redisinstance/definition.yml#L7-L42 |
||
* [`server.port`](https://opentelemetry.io/docs/specs/semconv/attributes-registry/server/) | ||
|
||
#### Entity tags [#redis-entity-tags] | ||
|
||
* `redis.version` | ||
* `redis.role` | ||
* [`host.type`](https://opentelemetry.io/docs/specs/semconv/attributes-registry/host) | ||
* [`cloud.provider`](https://opentelemetry.io/docs/specs/semconv/attributes-registry/cloud) | ||
* [`cloud.account.id`](https://opentelemetry.io/docs/specs/semconv/attributes-registry/cloud) | ||
* [`cloud.region`](https://opentelemetry.io/docs/specs/semconv/attributes-registry/cloud) | ||
* `instrumenation.name` | ||
* [`server.address`](https://opentelemetry.io/docs/specs/semconv/attributes-registry/server/) | ||
* [`server.port`](https://opentelemetry.io/docs/specs/semconv/attributes-registry/server/) | ||
|
||
## Supported entity relationships [#supported-entity-relationships] | ||
|
||
New Relic supports relationships between entities sourced from | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
188 changes: 0 additions & 188 deletions
188
.../get-started/collector-infra-monitoring/opentelemetry-collector-infra-redis.mdx
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alanwest need to differentiate between the required / recommended / entity tags sections for each entity type.