Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move opentelemetry redis example to examples repository #17555

Merged
merged 2 commits into from
Jun 7, 2024

Conversation

jack-berg
Copy link
Contributor

Depends on first merging corresponding PR here: newrelic/newrelic-opentelemetry-examples#608

Copy link

github-actions bot commented Jun 5, 2024

Hi @jack-berg 👋

Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

We will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 10 to 20 minutes).

Copy link

netlify bot commented Jun 5, 2024

Deploy Preview for docs-website-netlify ready!

Name Link
🔨 Latest commit 46e8367
🔍 Latest deploy log https://app.netlify.com/sites/docs-website-netlify/deploys/66622b6c99f3f10008c075aa
😎 Deploy Preview https://deploy-preview-17555--docs-website-netlify.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.


* [`service.name`](https://opentelemetry.io/docs/specs/semconv/attributes-registry/service): The service name you see in the UI comes from this value.

#### Recommended attributes [#recommended-attributes]
#### Recommended attributes [#service-recommended-attributes]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alanwest need to differentiate between the required / recommended / entity tags sections for each entity type.


#### Required attributes [#redis-required-attributes]

* [`server.address`](https://opentelemetry.io/docs/specs/semconv/attributes-registry/server/): The redis instance name you see in the UI comes from this value.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ally-sassman ally-sassman added content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers) labels Jun 6, 2024
@ally-sassman
Copy link
Contributor

@jack-berg This is ready to be merged once you give the green light!

@jack-berg
Copy link
Contributor Author

@jack-berg This is ready to be merged once you give the green light!

Good to go!

@ally-sassman ally-sassman merged commit c4bbd41 into newrelic:develop Jun 7, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants