-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move opentelemetry redis example to examples repository #17555
Conversation
Hi @jack-berg 👋 Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days. We will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 10 to 20 minutes). |
✅ Deploy Preview for docs-website-netlify ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
||
* [`service.name`](https://opentelemetry.io/docs/specs/semconv/attributes-registry/service): The service name you see in the UI comes from this value. | ||
|
||
#### Recommended attributes [#recommended-attributes] | ||
#### Recommended attributes [#service-recommended-attributes] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alanwest need to differentiate between the required / recommended / entity tags sections for each entity type.
|
||
#### Required attributes [#redis-required-attributes] | ||
|
||
* [`server.address`](https://opentelemetry.io/docs/specs/semconv/attributes-registry/server/): The redis instance name you see in the UI comes from this value. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See entity definition for reference: https://github.com/newrelic/entity-definitions/blame/c13e7a5d7150556c3980a64cd44047f70f3bdca0/entity-types/infra-redisinstance/definition.yml#L7-L42
@jack-berg This is ready to be merged once you give the green light! |
Good to go! |
Depends on first merging corresponding PR here: newrelic/newrelic-opentelemetry-examples#608