Add details to supported BTC addresses in omnilock #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quake
previously approved these changes
May 8, 2024
|
Omnilock has not fully supported the P2SH BTC address format, and we can not distinguish P2SH-P2WPKH addresses from other P2SH addresses. Considering this, mentioning P2SH-P2WPKH addresses without warning can cause permanent locking of assets. We should remove the P2SH-P2WPKH address format or at least explicitly warn developers. |
|
I think it can be mentioned that the omnilock only supports P2SH-P2WPKH but not generic P2SH. |
|
Do you think we need to tell developers that we strongly recommend NOT to use P2SH addresses to avoid mis-locking? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.