Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add details to supported BTC addresses in omnilock #439

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add details to supported BTC addresses in omnilock #439

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d04a9e3
Add details to supported BTC addresses in omnilock
XuJiandong May 8, 2024
1b6748e
More details to P2SH
XuJiandong May 8, 2024
fc715eb
Add details to P2SH
XuJiandong May 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion rfcs/0042-omnilock/0042-omnilock.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,16 @@ Depending on the value of the flag, the auth content has the following interpret
```
"CKB (Bitcoin Layer) transaction: 0x" + hex(signing message hash)
```
In this way, it can show message on wallets(e.g. UniSat, OKX) nicely.
In this way, it can show message on wallets(e.g. UniSat, OKX) nicely.

It supports three types of BTC addresses: Native segwit (P2WPKH), Nested
segwit (P2SH-P2WPKH), and Legacy (P2PKH). A 20-byte hash can be decoded from a
BTC address using bech32m/bech32 or base58. This hash exactly corresponds to
the auth content. Note that the Taproot (P2TR) address is not supported.
Generic P2SH is not supported; only P2SH-P2WPKH is acceptable. It's not
allowed to use an address (e.g. P2SH-multisig) described as P2SH but does not
include P2WPKH.


* 0x05: It follows the unlocking method used by dogecoin. The signing message
hash is converted as following:
Expand Down
Loading