Skip to content

Commit

Permalink
TASK: remove dg/bypass-finals as it leads to weird side effects with …
Browse files Browse the repository at this point in the history
…other tests
  • Loading branch information
skurfuerst committed May 4, 2022
1 parent 07e115d commit a2865c3
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 4 deletions.
2 changes: 1 addition & 1 deletion Tests/Unit/EventListener/EventListenerInvokerTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ class EventListenerInvokerTest extends UnitTestCase
/** @noinspection ClassMockingCorrectnessInspection */
public function setUp(): void
{
BypassFinals::enable();
$this->markTestSkipped('We need to fix these tests (to not rely on dg/bypass-finals');
$this->mockEventStore = $this->getMockBuilder(EventStore::class)->disableOriginalConstructor()->getMock();

$this->mockConnection = $this->getMockBuilder(Connection::class)->disableOriginalConstructor()->getMock();
Expand Down
2 changes: 1 addition & 1 deletion Tests/Unit/Projection/ProjectionManagerTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ class ProjectionManagerTest extends UnitTestCase
*/
public function setUp(): void
{
BypassFinals::enable();
$this->markTestSkipped('We need to fix these tests (to not rely on dg/bypass-finals');

$this->mockReflectionService = $this->createMock(ReflectionService::class);
$md5 = md5((string)time());
Expand Down
3 changes: 1 addition & 2 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,7 @@
"ramsey/uuid": "^3.9 || ^4.0"
},
"require-dev": {
"roave/security-advisories": "dev-master",
"dg/bypass-finals": "^1.2"
"roave/security-advisories": "dev-master"
},
"autoload": {
"psr-4": {
Expand Down

0 comments on commit a2865c3

Please sign in to comment.