Merge pull request #311 from neos/bugfix/309-fix-self-referencing-ret…

…urn-types

This change corrects return types to "static" where late static

Classes/AbstractEventSourcedAggregateRoot.php

@@ -49,7 +49,7 @@ final public function getReconstitutionVersion(): int
         return $this->reconstitutionVersion;
     }
 
-    final public static function reconstituteFromEventStream(EventStream $stream): self
+    final public static function reconstituteFromEventStream(EventStream $stream): static
     {
         $instance = new static();
         $lastAppliedEventVersion = -1;

Classes/Event/EventTypeResolver.php

@@ -56,7 +56,7 @@ public function injectObjectManager(ObjectManagerInterface $objectManager): void
      */
     public function initializeObject(): void
     {
-        $this->mapping = static::eventTypeMapping($this->objectManager);
+        $this->mapping = self::eventTypeMapping($this->objectManager);
         $this->reversedMapping = array_flip($this->mapping);
     }
 

Classes/EventListener/AppliedEventsStorage/DefaultAppliedEventsStorage.php

@@ -55,7 +55,7 @@ protected function __construct(string $eventListenerIdentifier)
      */
     public static function forEventListener(EventListenerInterface $listener): self
     {
-        return new static(\get_class($listener));
+        return new DefaultAppliedEventsStorage(\get_class($listener));
     }
 
     /**

Classes/EventListener/Mapping/EventToListenerMapping.php

@@ -45,7 +45,7 @@ private function __construct(string $eventClassName, string $listenerClassName,
 
     public static function create(string $eventClassName, string $listenerClassName, array $options): self
     {
-        return new static($eventClassName, $listenerClassName, $options);
+        return new self($eventClassName, $listenerClassName, $options);
     }
 
     public function getEventClassName(): string

Classes/EventPublisher/DeferEventPublisher.php

@@ -39,7 +39,7 @@ protected function __construct(EventPublisherInterface $wrappedEventPublisher)
 
     public static function forPublisher(EventPublisherInterface $eventPublisher): self
     {
-        return new static($eventPublisher);
+        return new DeferEventPublisher($eventPublisher);
     }
 
     /**

Classes/EventStore/WritableEvents.php

@@ -37,14 +37,14 @@ public static function fromArray(array $events): self
                 throw new \InvalidArgumentException(sprintf('Only instances of WritableEvent are allowed, given: %s', \is_object($event) ? \get_class($event) : \gettype($event)), 1540316594);
             }
         }
-        return new static(array_values($events));
+        return new self(array_values($events));
     }
 
     public function append(WritableEvent $event): self
     {
         $events = $this->events;
         $events[] = $event;
-        return new static($events);
+        return new self($events);
     }
 
     /**