FEATURE: implements @private #158
Conversation
Jan3k3y
commented
Mar 10, 2023
•
Jan3k3y
commented
- Use @Private in Headline and Slider
- Refactor Slider renderer into afx
- todo for refactor slider component
|
further todo would be to look at all usages of |
Jan3k3y
force-pushed
the
task/privateProps
branch
2 times, most recently
from
0a49dae to
57197c6
Compare
- @Private in Headline, Book and Slider - rewrote Slider renderer into afx - todo for refactor slider component
ahaeslich
force-pushed
the
task/privateProps
branch
from
57197c6 to
df9cbf4
Compare
| ` | ||
| } | ||
|
|
||
| //todo rework this component, to verify what is used and/or needed |
There was a problem hiding this comment.
@mhsdesign and/or @Jan3k3y do you still want to work on this todo?
| @@ -18,37 +19,36 @@ prototype(Neos.Demo:Presentation.Slider) < prototype(Neos.Fusion:Component) { | |||
| gap = 12 | |||
| } | |||
|
|
|||
| attributes = Neos.Fusion:DataStructure | |||
There was a problem hiding this comment.
Did you notice that with removing this and the following changes for attributes you can't add additional attributes to the slider anymore? So this refactoring would change the components behaviour.
There was a problem hiding this comment.
I wouldn't change the interface in such a PR
There was a problem hiding this comment.
we actually dont need the attributes ourselves (for the integration)
so this was only exposed so possibly other people could use the slider component themselves?
This seems like an odd concept - as for me the neos demo is just a demo without any contract and any expectations any guarantees -> Otherwise our refactor and redesign from 8.2 to 8.3 would have been breaking and illegal.
So i disagree. Imo we are allowed to change it, and in our case it makes the component easier to maintain and migrate to private props.
|
Guess we did not finish this for the release of 8.3.0 but would be a nice update afterwards :) |
| @@ -18,37 +19,36 @@ prototype(Neos.Demo:Presentation.Slider) < prototype(Neos.Fusion:Component) { | |||
| gap = 12 | |||
| } | |||
|
|
|||
| attributes = Neos.Fusion:DataStructure | |||
There was a problem hiding this comment.
I wouldn't change the interface in such a PR
|
Whats the status here? |
|
feel free for anyone to pick up this work ;) |
|
@Jan3k3y & @mhsdesign do you want to finish this and add an |
