Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: New content #142

Merged
merged 146 commits into from
Apr 1, 2023
Merged

FEATURE: New content #142

merged 146 commits into from
Apr 1, 2023

Conversation

Sebobo
Copy link
Member

@Sebobo Sebobo commented Jul 21, 2022

Depends on #137

@mficzel mficzel force-pushed the feature/new-content branch from 5bfdfd8 to 21d9e53 Compare March 9, 2023 09:10
@Sebobo
Copy link
Member Author

Sebobo commented Mar 16, 2023

@ahaeslich @mficzel are we done here now?

We might need to update the content export with the blog pages so we don't have inconsistencies, but is there anything else?

@mficzel
Copy link
Member

mficzel commented Mar 21, 2023

Content for the blog would be great and I think we wanted to add some BlogList content element

…ontainer` and `Cards.Cart` on the presentation side
@mficzel
Copy link
Member

mficzel commented Mar 23, 2023

I pushed a new commit wich adds Content.BlogPostingListand introduces Cards.Container and Cards.Cart on the presentation side`

Both are still ugly even though i tried to use the card components from https://tailwind-elements.com/docs/standard/components/cards/ .. so someone with little tailwind knowhow and a non-backend eye should adjust those.

@ahaeslich ahaeslich force-pushed the feature/new-content branch from cd14d9e to 8f0a9e6 Compare March 24, 2023 16:52
@ahaeslich
Copy link
Member

ahaeslich commented Mar 24, 2023

@ahaeslich @mficzel are we done here now?

We might need to update the content export with the blog pages so we don't have inconsistencies, but is there anything else?

Done ✅

@ahaeslich ahaeslich marked this pull request as ready for review March 24, 2023 17:11
@ahaeslich
Copy link
Member

ahaeslich commented Mar 24, 2023

@Sebobo & @mficzel I think we can merge this now and add all improvements in smaller merge requests

I would check and add #158 afterwards.

@mficzel mficzel self-requested a review March 24, 2023 17:55
Copy link
Member

@mficzel mficzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree to get this in now and fix remaining issues later. Actually like the state but would like to know what @Sebobo and @jonnitto say.

@mhsdesign
Copy link
Member

Happy to see that we are on the final track ;)

i guess Jon and Seb will have a closer look at the demo on the neos to 100 day and if they find something we can still correct it then ;)

@mficzel
Copy link
Member

mficzel commented Mar 25, 2023

Yes I would not wait for feedback but give them some days.

@ahaeslich ahaeslich merged commit 7c2c854 into 8.3 Apr 1, 2023
@ahaeslich ahaeslich deleted the feature/new-content branch April 1, 2023 15:15
@mficzel
Copy link
Member

mficzel commented Apr 4, 2023

Hmm ... this change breaks functional tests in the neos-development collection because of dropping the .html suffix. Do we want this that much to adjust the tests or do we want to revert that part.

2) Neos\Neos\Tests\Functional\Service\LinkingServiceTest::linkingServiceCreatesUriViaGivenNodeObject
Failed asserting that '/en/home' ends with "en/home.html".

/var/www/html/Packages/Neos/Neos.Neos/Tests/Functional/Service/LinkingServiceTest.php:336
/var/www/html/Packages/Neos/Neos.Neos/Tests/Functional/Service/LinkingServiceTest.php:149
/var/www/html/bin/phpunit:123

3) Neos\Neos\Tests\Functional\Service\LinkingServiceTest::linkingServiceCreatesUriViaAbsoluteNodePathString
Failed asserting that '/en/home' ends with "en/home.html".

/var/www/html/Packages/Neos/Neos.Neos/Tests/Functional/Service/LinkingServiceTest.php:336
/var/www/html/Packages/Neos/Neos.Neos/Tests/Functional/Service/LinkingServiceTest.php:157
/var/www/html/bin/phpunit:123

4) Neos\Neos\Tests\Functional\Service\LinkingServiceTest::linkingServiceCreatesUriViaStringStartingWithTilde
Failed asserting that '/en/home' ends with "en/home.html".

.... and so on

@mhsdesign
Copy link
Member

mhsdesign commented Apr 4, 2023

@mficzel i think we should fix the tests instead of reintroducing the suffix ^^ (discussed with @ahaeslich)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Demo for Neos 8.3
6 participants