remove adapter specific bang function

lib/backpex/adapter.ex

@@ -27,14 +27,7 @@ defmodule Backpex.Adapter do
 
   Should return `nil` if no result was found.
   """
-  @callback get(term(), term(), term()) :: term()
-
-  @doc """
-  Gets a database record with the given primary key value.
-
-  Should raise an exception if no result was found.
-  """
-  @callback get!(term(), term(), term()) :: term()
+  @callback get(term(), map(), module()) :: {:ok, struct() | nil} | {:error, term()}
 
   @doc """
   Returns a list of items by given criteria.

lib/backpex/adapters/ash.ex

@@ -38,21 +38,6 @@ if Code.ensure_loaded?(Ash) do
       |> Ash.read_one()
     end
 
-    @doc """
-    Gets a database record with the given primary key value.
-
-    Raises an error if no record was found.
-    """
-    @impl Backpex.Adapter
-    def get!(primary_value, _assigns, live_resource) do
-      config = live_resource.config(:adapter_config)
-      primary_key = live_resource.config(:primary_key)
-
-      config[:resource]
-      |> Ash.Query.filter(^Ash.Expr.ref(primary_key) == ^primary_value)
-      |> Ash.read_one!()
-    end
-
     @doc """
     Returns a list of items by given criteria.
     """

lib/backpex/adapters/ecto.ex

@@ -66,8 +66,6 @@ defmodule Backpex.Adapters.Ecto do
 
   @doc """
   Gets a database record with the given primary key value.
-
-  Returns `nil` if no result was found.
   """
   @impl Backpex.Adapter
   def get(primary_value, assigns, live_resource) do
@@ -76,20 +74,7 @@ defmodule Backpex.Adapters.Ecto do
 
     record_query(primary_value, config[:schema], item_query, live_resource)
     |> config[:repo].one()
-  end
-
-  @doc """
-  Gets a database record with the given primary key value.
-
-  Raises `Ecto.NoResultsError` if no record was found.
-  """
-  @impl Backpex.Adapter
-  def get!(primary_value, assigns, live_resource) do
-    config = live_resource.config(:adapter_config)
-    item_query = prepare_item_query(config, assigns)
-
-    record_query(primary_value, config[:schema], item_query, live_resource)
-    |> config[:repo].one!()
+    |> then(fn result -> {:ok, result} end)
   end
 
   @doc """

lib/backpex/exceptions.ex

@@ -1,16 +1,9 @@
-defmodule Backpex.NoResourceError do
+defmodule Backpex.NoResultsError do
   @moduledoc """
-  Raised when resource can not be found.
-
-  If you are seeing this error, you should check if you provided the correct identifier for the requested resource.
+  Raised when no results can be found.
   """
 
-  defexception message: "Resource not found", plug_status: 404
-
-  def exception(opts) do
-    name = Keyword.fetch!(opts, :name)
-    %__MODULE__{message: "no resource found for:\n\n#{inspect(name)}"}
-  end
+  defexception message: "No results could be found", plug_status: 404
 end
 
 defmodule Backpex.ForbiddenError do

lib/backpex/live_resource.ex

@@ -1140,7 +1140,7 @@ defmodule Backpex.LiveResource do
     %{live_resource: live_resource, live_action: live_action} = socket.assigns
 
     item_primary_value = primary_value(socket, item)
-    item = Resource.get(item_primary_value, socket.assigns, live_resource)
+    {:ok, item} = Resource.get(item_primary_value, socket.assigns, live_resource)
 
     socket =
       cond do

lib/backpex/resource.ex

@@ -40,35 +40,37 @@ defmodule Backpex.Resource do
   @doc """
   Gets a database record with the given `fields` by the given  `primary_value`.
 
-  Raises `Ecto.NoResultsError` if no record was found.
+  Returns `{:ok, nil}` if no result was found.
 
   ## Parameters
 
   * `primary_value`: The identifier for the specific item to be fetched.
   * `assigns` (map): The current assigns of the socket.
   * `live_resource` (module): The `Backpex.LiveResource` module.
   """
-  def get!(primary_value, assigns, live_resource) do
+  def get(primary_value, assigns, live_resource) do
     adapter = live_resource.config(:adapter)
 
-    adapter.get!(primary_value, assigns, live_resource)
+    adapter.get(primary_value, assigns, live_resource)
   end
 
   @doc """
   Gets a database record with the given `fields` by the given  `primary_value`.
 
-  Returns `nil` if no result was found.
+  Raises `Backpex.NoResultsError` if no record was found.
 
   ## Parameters
 
   * `primary_value`: The identifier for the specific item to be fetched.
   * `assigns` (map): The current assigns of the socket.
   * `live_resource` (module): The `Backpex.LiveResource` module.
   """
-  def get(primary_value, assigns, live_resource) do
-    adapter = live_resource.config(:adapter)
-
-    adapter.get!(primary_value, assigns, live_resource)
+  def get!(primary_value, assigns, live_resource) do
+    case get(primary_value, assigns, live_resource) do
+      {:ok, nil} -> raise Backpex.NoResultsError
+      {:ok, result} -> result
+      {:error, _error} -> raise Backpex.NoResultsError
+    end
   end
 
   @doc """