remove adapter specific bang function #667
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pehbehbeh
commented
Nov 14, 2024
| @@ -1,16 +1,9 @@ | |||
| defmodule Backpex.NoResourceError do | |||
There was a problem hiding this comment.
NoResourceError is not used anymore, as far as I can see.
Comment on lines
+69
to
+73
| case get(primary_value, assigns, live_resource) do | ||
| {:ok, nil} -> raise Backpex.NoResultsError | ||
| {:ok, result} -> result | ||
| {:error, _error} -> raise Backpex.NoResultsError | ||
| end |
There was a problem hiding this comment.
@Flo0807 Like this? I think we should work with result tuples everywhere (like Ash for example).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP