feat(iroh-net-report)!: add QUIC address discovery probes

iroh-net-report/src/lib.rs

@@ -241,6 +241,13 @@ impl Client {
     ///
     /// If these are not passed in this will bind sockets for STUN itself, though results
     /// may not be as reliable.
+    ///
+    /// The *quic_config* takes a [`QuicConfig`], a combination of a QUIC endpoint and
+    /// a client configuration that can be use for verifying the relay server connection.
+    /// When available, the report will attempt to get an observed public address
+    /// using QUIC address discovery.
+    ///
+    /// When `None`, it will disable the QUIC address discovery probes.
     pub async fn get_report(
         &mut self,
         dm: RelayMap,

iroh-net-report/src/reportgen.rs

@@ -885,8 +885,6 @@ async fn run_stun_probe(
 }
 
 /// Run a QUIC address discovery probe.
-// TODO(ramfox): if this probe is aborted, then the connection will never be
-// properly closed, possibly causing errors on the server.
 async fn run_quic_probe(
     quic_config: QuicConfig,
     url: RelayUrl,
@@ -898,8 +896,15 @@ async fn run_quic_probe(
         ProbeProto::QuicIpv6 => debug_assert!(relay_addr.is_ipv6()),
         _ => debug_assert!(false, "wrong probe"),
     }
-    // TODO(ramfox): what to put here if no host is given?
-    let host = url.host_str().unwrap_or("localhost");
+    let host = match url.host_str() {
+        Some(host) => host,
+        None => {
+            return Err(ProbeError::Error(
+                anyhow!("URL must have 'host' to use QUIC address discovery probes"),
+                probe.clone(),
+            ));
+        }
+    };
     let quic_client = iroh_relay::quic::QuicClient::new(quic_config.ep, quic_config.client_config)
         .map_err(|e| ProbeError::Error(e, probe.clone()))?;
     let (addr, latency) = quic_client

iroh-net-report/src/reportgen/probes.rs

@@ -92,12 +92,12 @@ pub(super) enum Probe {
         delay: Duration,
         node: Arc<RelayNode>,
     },
-    #[display("QUIC Address Discovery Ivp4 after {delay:?} to {node}")]
+    #[display("QAD Ipv4 after {delay:?} to {node}")]
     QuicIpv4 {
         delay: Duration,
         node: Arc<RelayNode>,
     },
-    #[display("QUIC Address Discovery Ivp6 after {delay:?} to {node}")]
+    #[display("QAD Ipv6 after {delay:?} to {node}")]
     QuicIpv6 {
         delay: Duration,
         node: Arc<RelayNode>,