feat(iroh-net-report)!: add QUIC address discovery probes #3028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramfox
commented
Dec 11, 2024
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3028/docs/iroh/ Last updated: 2024-12-11T19:30:38Z |
ramfox
changed the title
8 tasks
flub
reviewed
Dec 12, 2024
| probe.clone(), | ||
| )); | ||
| } | ||
| }; |
There was a problem hiding this comment.
FYI this is a prime place for using the fancy new-ish syntax of let Some(host) = url.host_str() else { return ... }; Not important enough to follow up on though.
flub
reviewed
Dec 12, 2024
| let host = match url.host_str() { | ||
| Some(host) => host, | ||
| None => { | ||
| return Err(ProbeError::Error( |
There was a problem hiding this comment.
Hum, I believe this should be ProbeError::AbortSet? Why did you choose just this one? If the RelayUrl has no host none of the retries after a small delay will work either.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds probes for QUIC Address Discovery.
Breaking Changes
iroh-net-reportiroh_net_report::Client::get_reporttakes new parameterquic_config: net_report::QuicConfigiroh_net_report::Client::get_report_channeltakes new parameterquic_config: net_report::QuicConfigNotes & open questions
Next PR is properly adding this to iroh (& a new PR for iroh-doctor).
magicsock.rswas adjusted so thatirohcan still depend on the repo version ofnet-report, but does not enable QAD.Change checklist