refactor(iroh)!: replace public fields in iroh client with accessors and use ref-cast to eliminate them entirely #2350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lets keep the fields and deprecate them in this PR, and drop them only in the next release |
|
I asked on the public discord. For what it's worth, people seem to be in favour of this change: |
rklaehn
force-pushed
the
iroh-client-fields
branch
from
453c5d4 to
e9f0350
Compare
dignifiedquire
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With 4 different clients, the current approach might be OK. But we are going to have more. E.g. gossip, see #2258 .
And in any case it feels weird to store the same thing multiple times.
So this replaces public fields in the iroh client with accessors and use ref-cast to eliminate them entirely. There is now only one rpc field, and you can switch from that to the different subsystem client views without runtime overhead, not even an arc clone.
Breaking Changes
Everything that uses the iroh client will have to switch from field accesses to accessor fns.
Notes & open questions
Change checklist