-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5841 gaps item import script is incorrect #5883
base: develop
Are you sure you want to change the base?
Conversation
@@ -0,0 +1,108 @@ | |||
import csv |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed, a comment up the top here to explain the purpose/status of this script would be good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Holding off on further review pending @jmbrunskill looking at updating the spreadsheet to include item ID, as discussed IRL
@CarlosNZ I've decided that there's too many ids to manage in that spreadsheet. |
Fixes #5841
π©π»βπ» What does this PR do?
Uses a new mSupply Item Code (created using the python script in this PR) but now is in the spreadsheet as a VLOOKUP.
Volumes are now divided by 1000 to make them in litres
Cold Storage Type look up is improved.
π Any notes for the reviewer?
If you're brave and want to mostly start again.. you could consider running this.
However might not be correct, definitely don't run it on production..
π§ͺ Testing
π Documentation
1.
2.