Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GAPS item import script is incorrect #5841

Closed
jmbrunskill opened this issue Dec 17, 2024 · 2 comments · Fixed by #5883
Closed

GAPS item import script is incorrect #5841

jmbrunskill opened this issue Dec 17, 2024 · 2 comments · Fixed by #5883
Assignees
Labels
bug Something is borken Severity: High Bugs breaking core functionality or with no/unacceptable workaround. High impact. Next patch release Team Piwakawaka James, Chris, Carl
Milestone

Comments

@jmbrunskill
Copy link
Contributor

jmbrunskill commented Dec 17, 2024

What went wrong? 😲

Some items were incorrectly conflated due to duplicate mSupply item_codes created.
We need to separate these out so they're not duplicated.

Packaging Volumes are off by a factor of 1000 (needs a conversion)

Cold storage types are mapped based on names or strict mapping, should be based on a range e.g. +5 should be between 0 and 10 degrees -20 between -30 and -10, etc.

Variant names are too long and can't be viewed correctly in the UI

Expected behaviour 🤔

Improved setup of gaps items

How to Reproduce 🔨

Steps to reproduce the behaviour:

  1. Run create_gaps_item_sql_script
  2. Run the output in the generated file (on a fresh db)
  3. Check the items are setup correctly

Your environment 🌱

  • Open mSupply Version:
  • Legacy mSupply Central Server Version:
  • Platform:
  • Database type:
@jmbrunskill jmbrunskill added bug Something is borken needs triage needs daily triage New bug to be triaged by the release team labels Dec 17, 2024
@jmbrunskill jmbrunskill self-assigned this Dec 17, 2024
@adamdewey
Copy link
Contributor

I think good to go with these ranges @jmbrunskill

telegram-cloud-photo-size-1-5118440980981329433-y

@jmbrunskill jmbrunskill added this to the v2.5.0 milestone Dec 17, 2024
@jmbrunskill jmbrunskill added Severity: High Bugs breaking core functionality or with no/unacceptable workaround. High impact. Next patch release Team Piwakawaka James, Chris, Carl and removed needs triage needs daily triage New bug to be triaged by the release team labels Dec 17, 2024
@adamdewey
Copy link
Contributor

adamdewey commented Dec 20, 2024

One other thing @jmbrunskill - some of the variant names are too long and user can't distinguish between them in the UI as they get cut off.

So think we need to revisit the naming...

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is borken Severity: High Bugs breaking core functionality or with no/unacceptable workaround. High impact. Next patch release Team Piwakawaka James, Chris, Carl
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants