Skip to content
This repository has been archived by the owner on Feb 11, 2020. It is now read-only.

Add A/B testing for our about sidebar text in EN locales #2130

Closed
wants to merge 4 commits into from

Conversation

Pomax
Copy link
Contributor

@Pomax Pomax commented Dec 17, 2018

This adds a new string to the messages.properties for en-US only, as per #2129, and adds an A/B test that does a 50/50 content swap between the original text and the new text.

@Pomax Pomax requested a review from alanmoo December 17, 2018 19:25
@cadecairos cadecairos temporarily deployed to donate-mozilla-org-us--pr-2130 December 17, 2018 19:25 Inactive
@Pomax Pomax temporarily deployed to donate-mozilla-org-us--pr-2130 December 17, 2018 19:27 Inactive
Copy link
Contributor

@TheoChevalier TheoChevalier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

String change looks good — assuming it will be deployed to all locales on the 28th if it’s winning in EN.

@alanmoo
Copy link
Contributor

alanmoo commented Dec 17, 2018

I would assume so too. @WillatMozFdn can you confirm?

@WillatMozFdn
Copy link

Yes, that would be ideal if we can. Thanks @TheoChevalier

@TheoChevalier
Copy link
Contributor

Sounds good, let’s merge this sooner rather than later then :)

@Pomax
Copy link
Contributor Author

Pomax commented Dec 18, 2018

We can even land it immediately if we want, with the original text set to 100%, if we don't want to start testing the new text until the 21st. The code knows how to handle more than one active test at a time.

Copy link
Contributor

@alanmoo alanmoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to work, but IE11 is getting A/B again? Even in prod? I'm confused, I thought we blocked it from running TrafficCop?

@Pomax
Copy link
Contributor Author

Pomax commented Dec 20, 2018

I have no idea what Travis is doing. Somehow webpack's failing even though it shouldn't because it's supposedly using webpack 3.2.0, which is the correct version.

@alanmoo
Copy link
Contributor

alanmoo commented Dec 20, 2018

In addition to the webpack stuff, it seems like there's a handful of linting issues with the new file.

alanmoo added a commit that referenced this pull request Dec 20, 2018
Since the final commit in #2130 to fix IE stuff is what broke Travis (and it seems the current "IE is running AB tests" is in production, I want to land this branch, which is #2130 without its most recent commit, plus reduction of the AB test implemented here to 0% while the other test finishes running. This way localizers can get their hands on this prior to flipping the switch next week. 

cc @Pomax
@alanmoo
Copy link
Contributor

alanmoo commented Dec 20, 2018

IE11 seems to be working (at least, I fully tested it on staging) so I guess let's hold off on landing this?

@Pomax
Copy link
Contributor Author

Pomax commented Jan 22, 2019

assuredinfantilejaguar-small

@Pomax Pomax closed this Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants