-
Notifications
You must be signed in to change notification settings - Fork 48
Add A/B testing for our about sidebar text in EN locales #2130
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
String change looks good — assuming it will be deployed to all locales on the 28th if it’s winning in EN.
I would assume so too. @WillatMozFdn can you confirm? |
Yes, that would be ideal if we can. Thanks @TheoChevalier |
Sounds good, let’s merge this sooner rather than later then :) |
We can even land it immediately if we want, with the original text set to 100%, if we don't want to start testing the new text until the 21st. The code knows how to handle more than one active test at a time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to work, but IE11 is getting A/B again? Even in prod? I'm confused, I thought we blocked it from running TrafficCop?
I have no idea what Travis is doing. Somehow webpack's failing even though it shouldn't because it's supposedly using webpack 3.2.0, which is the correct version. |
In addition to the webpack stuff, it seems like there's a handful of linting issues with the new file. |
Since the final commit in #2130 to fix IE stuff is what broke Travis (and it seems the current "IE is running AB tests" is in production, I want to land this branch, which is #2130 without its most recent commit, plus reduction of the AB test implemented here to 0% while the other test finishes running. This way localizers can get their hands on this prior to flipping the switch next week. cc @Pomax
IE11 seems to be working (at least, I fully tested it on staging) so I guess let's hold off on landing this? |
This adds a new string to the messages.properties for
en-US
only, as per #2129, and adds an A/B test that does a 50/50 content swap between the original text and the new text.